Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tightly control enabled/primary methods #23

Closed
pkevan opened this issue Nov 29, 2022 · 4 comments
Closed

More tightly control enabled/primary methods #23

pkevan opened this issue Nov 29, 2022 · 4 comments
Assignees
Milestone

Comments

@pkevan
Copy link
Contributor

pkevan commented Nov 29, 2022

Currently it's possible to select and configure primary methods - make this non-configurable for users.

Enabled as an option should not be visible too (perhaps hard coded in the theme?)

@pkevan
Copy link
Contributor Author

pkevan commented Nov 29, 2022

Related: #15

@iandunn
Copy link
Member

iandunn commented Nov 29, 2022

make this non-configurable for users.

Once WebAuthn is added upstream, we'll have 3 methods available: WebAuthn, TOTP, and Backup Codes. I think WebAuthn and TOTP are both valid as primary, so won't we need a way to let folks choose between them?

I can see someone with WebAuthn wanting to use TOTP as their secondary instead of Backup Codes, but maybe that's an edge case, and being opinionated will simplify the UI/setup. I do think it's nice to allow all 3 to be activated, though, as extra protection against losing a key/phone.

Enabled as an option should not be visible too (perhaps hard coded in the theme?)

What do you mean by that?

@pkevan
Copy link
Contributor Author

pkevan commented Nov 30, 2022

won't we need a way to let folks choose between them?

It probably depends if we want to consider giving them an option to choose, as in the first method presented to them on a 2FA login. Or if it's too much of an edge case.

Enabled as an option should not be visible too (perhaps hard coded in the theme?)
What do you mean by that?

The current UI has a checkbox for enabled as well as primary. It feels a little confusing to show them and doesn't fit with the suggested UI, so guiding a user through that process and hiding it was what I meant.

@iandunn
Copy link
Member

iandunn commented Dec 1, 2022

guiding a user through that process and hiding it was what I meant.

yeah, i don't think we need primary in the UI. we can just force that to be webauthn (if set), then fallback to TOTP if not 👍🏻

@iandunn iandunn modified the milestones: MVP, Iteration 1 Jan 19, 2023
@iandunn iandunn modified the milestones: Iteration 1, MVP Feb 1, 2023
@iandunn iandunn self-assigned this Feb 1, 2023
@iandunn iandunn closed this as completed in 870b07d Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants