-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll out to SSO domains #13
Comments
Of those domains, only WordCamp doesn't force logins through login.wordpress.org. bbPress and BuddyPress already do so. |
Marking as completed, as all SSO domains now go through login.w.org |
Are there other things we need to consider? I added some in #16 Both plugins will still need to run on wordcamp.org etc, for #6 etc . We'll probably want to redirect the settings etc on those sites to go to the main settings on w.org though. There may be other things we haven't thought of yet, so testing on those sites would be good IMO. |
Hmm.. Yes, you're right, we'll want to force-enable the 2FA plugins on every WordPress that uses the shared tables, in addition to the single 2FA login.
This is something that we already need to do really, there's a lot of settings on wp-admin/profile.php that should not be changed there, and in the case of WordCamp, will cause the WordPress.org user data to get out of sync with the database. |
@dd32 , I'm hoping to launch the MVP this week, do you think you'll bandwidth to wrap up this issue? I think it should be fine to go ahead and install/activate the plugins on wordcamp.org/buddypress.org/etc now, since it's still hidden for beta testers wporg-two-factor/wporg-two-factor.php Lines 22 to 27 in db6b456
#16 has some rough notes on how I imagined we'd install/activate the plugins, but I don't feel strongly. |
I went ahead and installed/activated the plugins in #16 since I had time today. I think that just leaves removing the settings, but that seems like it can be done in the next milestone. I opened #52 for that, but if you've already started on it then there's no reason to stop. Is there anything else you think we should to here? |
I think we're good here. I've manually enabled the plugins on bbpress.org, as it's a single-site and not part of the buddypress.org network, despite sharing the same files. |
👍🏻 thanks! |
The plugins etc will also need to be added to wordcamp.org, buddypress.org, bbpress.org, etc; or those sites will need to force logins to go through login.w.org.
The text was updated successfully, but these errors were encountered: