You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At times, there may be contributors to a PR who haven't left a comment on the ticket/PR.
Example:
People with whom the PR was discussed in person, in a video-call or on Slack
I think it would be good if these could be added to the props list in a transparent and straight-forward manner.
Feature Request
I can think of a couple of possible solutions:
Being able to leave a comment on a PR in the "Unlinked contributors: nacin, matt." format.
Adding the "props-bot" label after leaving the comment should updated the props list and include the contributors mentioned in the "Unlinked contributors" comment.
Have a specific command which does both in one go. Something like @props-bot add nacin, matt, which would trigger the props-bot to update the props list with the mentioned names.
This feature would be susceptible to "props spam", i.e people triggering the bot to add people who have not contributed to the feature, but then again, this whole system is susceptible to "props spam" anyway as I regularly see people leaving a comment on PRs without any noteworthy input only to get props.
This seems like a duplicate of #22, and related to #48.
This feature would be susceptible to "props spam", i.e people triggering the bot to add people who have not contributed to the feature, but then again, this whole system is susceptible to "props spam" anyway as I regularly see people leaving a comment on PRs without any noteworthy input only to get props.
Unfortunately, I don't think we can ever fully account for this without a manual review step in this process. It's long been the practice for SVN to perform a manual review while collecting props, and it's recommended and documented in the new processes for Git.
Problem
At times, there may be contributors to a PR who haven't left a comment on the ticket/PR.
Example:
I think it would be good if these could be added to the props list in a transparent and straight-forward manner.
Feature Request
I can think of a couple of possible solutions:
Adding the "props-bot" label after leaving the comment should updated the props list and include the contributors mentioned in the "Unlinked contributors" comment.
@props-bot add nacin, matt
, which would trigger the props-bot to update the props list with the mentioned names.This feature would be susceptible to "props spam", i.e people triggering the bot to add people who have not contributed to the feature, but then again, this whole system is susceptible to "props spam" anyway as I regularly see people leaving a comment on PRs without any noteworthy input only to get props.
Workaround
No response
Repository
https://github.com/WordPress/wordpress-develop
The text was updated successfully, but these errors were encountered: