From b63b64c42c8bc502ee22e5d741f9b5c326d94124 Mon Sep 17 00:00:00 2001 From: Sainath Poojary Date: Wed, 26 Feb 2025 21:31:50 +0530 Subject: [PATCH 1/3] InputControl: Ensure consistent placeholder color --- .../src/input-control/styles/input-control-styles.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/components/src/input-control/styles/input-control-styles.tsx b/packages/components/src/input-control/styles/input-control-styles.tsx index db24a5e60f137a..9e942c8a31c52e 100644 --- a/packages/components/src/input-control/styles/input-control-styles.tsx +++ b/packages/components/src/input-control/styles/input-control-styles.tsx @@ -286,6 +286,15 @@ export const Input = styled.input< InputProps >` &::-webkit-input-placeholder { line-height: normal; + color: ${ COLORS.ui.darkGrayPlaceholder }; + } + + &::-moz-placeholder { + color: ${ COLORS.ui.darkGrayPlaceholder }; + } + + &:-ms-input-placeholder { + color: ${ COLORS.ui.darkGrayPlaceholder }; } &[type='email'], From 5567159813038003aee93e9e7d704b4f30b36804 Mon Sep 17 00:00:00 2001 From: Sainath Poojary Date: Thu, 27 Feb 2025 14:09:15 +0530 Subject: [PATCH 2/3] InputControl: Add CHANGELOG entry --- packages/components/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 5cdf14f89937f1..31cd61305a730c 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -5,6 +5,7 @@ ### Bug Fixes - `TextControl`: Ensures email and url inputs have consistent LTR alignment in RTL languages ([#68561](https://github.com/WordPress/gutenberg/pull/68561)). +- `InputControl`: Ensure consistent placeholder color ([#69334](https://github.com/WordPress/gutenberg/pull/69334)). ### Enhancement From 3d9a0007541900b8c3634fffd8e1b87d176180cb Mon Sep 17 00:00:00 2001 From: Sainath Poojary Date: Thu, 27 Feb 2025 14:34:11 +0530 Subject: [PATCH 3/3] InputControl: Remove unnecessary line-height styles --- .../components/src/input-control/styles/input-control-styles.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/components/src/input-control/styles/input-control-styles.tsx b/packages/components/src/input-control/styles/input-control-styles.tsx index 9e942c8a31c52e..492c4bef0f4e20 100644 --- a/packages/components/src/input-control/styles/input-control-styles.tsx +++ b/packages/components/src/input-control/styles/input-control-styles.tsx @@ -285,7 +285,6 @@ export const Input = styled.input< InputProps >` ${ customPaddings } &::-webkit-input-placeholder { - line-height: normal; color: ${ COLORS.ui.darkGrayPlaceholder }; }