From 87c2efbcd9f1b3226a531f61686c27292e878bf7 Mon Sep 17 00:00:00 2001 From: himanshupathak95 Date: Tue, 25 Feb 2025 21:46:18 +0530 Subject: [PATCH 1/3] Remove unnecessary opacity override for Firefox placeholders --- packages/base-styles/_mixins.scss | 1 - .../src/textarea-control/styles/textarea-control-styles.ts | 2 -- packages/editor/src/components/post-text-editor/style.scss | 2 -- 3 files changed, 5 deletions(-) diff --git a/packages/base-styles/_mixins.scss b/packages/base-styles/_mixins.scss index 9f089b8d9e832..e61541f027057 100644 --- a/packages/base-styles/_mixins.scss +++ b/packages/base-styles/_mixins.scss @@ -284,7 +284,6 @@ } &::-moz-placeholder { - opacity: 1; // Necessary because Firefox reduces this from 1. color: $dark-gray-placeholder; } diff --git a/packages/components/src/textarea-control/styles/textarea-control-styles.ts b/packages/components/src/textarea-control/styles/textarea-control-styles.ts index 022ce3560ea3a..84dd2da0e53c0 100644 --- a/packages/components/src/textarea-control/styles/textarea-control-styles.ts +++ b/packages/components/src/textarea-control/styles/textarea-control-styles.ts @@ -62,7 +62,6 @@ export const StyledTextarea = styled.textarea` } &::-moz-placeholder { - opacity: 1; // Necessary because Firefox reduces this from 1. color: ${ COLORS.ui.darkGrayPlaceholder }; } @@ -76,7 +75,6 @@ export const StyledTextarea = styled.textarea` } &::-moz-placeholder { - opacity: 1; // Necessary because Firefox reduces this from 1. color: ${ COLORS.ui.lightGrayPlaceholder }; } diff --git a/packages/editor/src/components/post-text-editor/style.scss b/packages/editor/src/components/post-text-editor/style.scss index 5391588d906d8..ad7b3383db2aa 100644 --- a/packages/editor/src/components/post-text-editor/style.scss +++ b/packages/editor/src/components/post-text-editor/style.scss @@ -41,8 +41,6 @@ textarea.editor-post-text-editor { &::-moz-placeholder { color: $dark-gray-placeholder; - // Override Firefox default. - opacity: 1; } &:-ms-input-placeholder { From 8b6eeb0c936ca371fc8741c6310e68389d9b4464 Mon Sep 17 00:00:00 2001 From: himanshupathak95 Date: Tue, 25 Feb 2025 23:54:37 +0530 Subject: [PATCH 2/3] Changelog: Add entry for TextareaControl --- packages/components/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 5cdf14f89937f..cab51bf9fec39 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +- `TextareaControl`: Fix Firefox placeholder text opacity override ([#69312](https://github.com/WordPress/gutenberg/pull/69312)). + ### Bug Fixes - `TextControl`: Ensures email and url inputs have consistent LTR alignment in RTL languages ([#68561](https://github.com/WordPress/gutenberg/pull/68561)). From cfef6e71354d3c62a479dbafddb72da6c533ad61 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 27 Feb 2025 13:58:58 +0100 Subject: [PATCH 3/3] Move changelog entry under the Enhancement section. --- packages/components/CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index cab51bf9fec39..284b873457e29 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -2,14 +2,13 @@ ## Unreleased -- `TextareaControl`: Fix Firefox placeholder text opacity override ([#69312](https://github.com/WordPress/gutenberg/pull/69312)). - ### Bug Fixes - `TextControl`: Ensures email and url inputs have consistent LTR alignment in RTL languages ([#68561](https://github.com/WordPress/gutenberg/pull/68561)). ### Enhancement +- `TextareaControl`: Fix Firefox placeholder text opacity override ([#69312](https://github.com/WordPress/gutenberg/pull/69312)). - `BorderControlDropdown`, `BorderControl`: Reset button is always visible. ([#69066](https://github.com/WordPress/gutenberg/pull/69066)). ### Internal