From 46022712d2dce340bd363e937066f996e3f9fb96 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Shah Date: Wed, 5 Feb 2025 02:20:59 +0530 Subject: [PATCH 1/4] NumberControl: Fix invalid HTML attributes for infinite bounds --- packages/components/src/number-control/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/src/number-control/index.tsx b/packages/components/src/number-control/index.tsx index 6dd1af4024af7..9e5f05ea6f3c6 100644 --- a/packages/components/src/number-control/index.tsx +++ b/packages/components/src/number-control/index.tsx @@ -229,8 +229,8 @@ function UnforwardedNumberControl( hideHTMLArrows={ spinControls !== 'native' } isDragEnabled={ isDragEnabled } label={ label } - max={ max } - min={ min } + min={ min === -Infinity ? undefined : min } + max={ max === Infinity ? undefined : max } ref={ mergedRef } required={ required } step={ step } From 4a6c4556623a425241ae363001ceeb96d10e65a9 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Shah Date: Wed, 5 Feb 2025 13:35:16 +0530 Subject: [PATCH 2/4] NumberControl: Maintain prop order --- packages/components/src/number-control/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/number-control/index.tsx b/packages/components/src/number-control/index.tsx index 9e5f05ea6f3c6..e890746e275e8 100644 --- a/packages/components/src/number-control/index.tsx +++ b/packages/components/src/number-control/index.tsx @@ -229,8 +229,8 @@ function UnforwardedNumberControl( hideHTMLArrows={ spinControls !== 'native' } isDragEnabled={ isDragEnabled } label={ label } - min={ min === -Infinity ? undefined : min } max={ max === Infinity ? undefined : max } + min={ min === -Infinity ? undefined : min } ref={ mergedRef } required={ required } step={ step } From f8301c423a880720aa2a61bbb63f38350cc68c92 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Shah Date: Wed, 12 Feb 2025 15:21:17 +0530 Subject: [PATCH 3/4] Add `CHANGELOG.md` entry --- packages/components/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index c487b0a17a288..8f9d5b0c5b77a 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Internal + +- `NumberControl`: Fix invalid HTML attributes for infinite bounds ([#69033](https://github.com/WordPress/gutenberg/pull/69033)). + ## 29.3.0 (2025-01-29) ### Enhancements From d4d17c8506b99512b395abbb051fe7e687434885 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Shah Date: Wed, 12 Feb 2025 15:26:47 +0530 Subject: [PATCH 4/4] Format `NumberControl` changelog entry --- packages/components/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 617be1d1e2036..e5b6286354456 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -4,7 +4,7 @@ ### Internal -- `NumberControl`: Fix invalid HTML attributes for infinite bounds ([#69033](https://github.com/WordPress/gutenberg/pull/69033)). +- `NumberControl`: Fix invalid HTML attributes for infinite bounds ([#69033](https://github.com/WordPress/gutenberg/pull/69033)). - `ComboboxControl`: Add an `isLoading` prop to show a loading spinner ([#68990](https://github.com/WordPress/gutenberg/pull/68990))