From 5adb8bea73a0a75a5065f19764ed0d5ca074ca9e Mon Sep 17 00:00:00 2001 From: Jerry Jones Date: Tue, 17 Sep 2024 09:44:10 -0700 Subject: [PATCH] Revert "Writing flow: fix triple click inside text blocks (#64928)" This reverts commit a3d1c078cf88ff84a1d902cd86337dfa83c32642. --- .../writing-flow/use-selection-observer.js | 9 --------- packages/dom/README.md | 16 ---------------- packages/dom/src/dom/index.js | 1 - 3 files changed, 26 deletions(-) diff --git a/packages/block-editor/src/components/writing-flow/use-selection-observer.js b/packages/block-editor/src/components/writing-flow/use-selection-observer.js index 8ecba461d1025..824e01d07358b 100644 --- a/packages/block-editor/src/components/writing-flow/use-selection-observer.js +++ b/packages/block-editor/src/components/writing-flow/use-selection-observer.js @@ -4,7 +4,6 @@ import { useSelect, useDispatch } from '@wordpress/data'; import { useRefEffect } from '@wordpress/compose'; import { create } from '@wordpress/rich-text'; -import { isSelectionForward } from '@wordpress/dom'; /** * Internal dependencies @@ -54,14 +53,6 @@ function extractSelectionEndNode( selection ) { return focusNode; } - // When the selection is forward (the selection ends with the focus node), - // the selection may extend into the next element with an offset of 0. This - // may trigger multi selection even though the selection does not visually - // end in the next block. - if ( focusOffset === 0 && isSelectionForward( selection ) ) { - return focusNode.previousSibling ?? focusNode.parentElement; - } - return focusNode.childNodes[ focusOffset ]; } diff --git a/packages/dom/README.md b/packages/dom/README.md index 26740c74e8561..5440ff2820ccc 100644 --- a/packages/dom/README.md +++ b/packages/dom/README.md @@ -239,22 +239,6 @@ _Returns_ - `boolean`: True if rtl, false if ltr. -### isSelectionForward - -Returns true if the given selection object is in the forward direction, or false otherwise. - -_Related_ - -- - -_Parameters_ - -- _selection_ `Selection`: Selection object to check. - -_Returns_ - -- `boolean`: Whether the selection is forward. - ### isTextContent _Parameters_ diff --git a/packages/dom/src/dom/index.js b/packages/dom/src/dom/index.js index 4522ac1fd1b89..f21ec1e4e85e6 100644 --- a/packages/dom/src/dom/index.js +++ b/packages/dom/src/dom/index.js @@ -24,4 +24,3 @@ export { default as isEmpty } from './is-empty'; export { default as removeInvalidHTML } from './remove-invalid-html'; export { default as isRTL } from './is-rtl'; export { default as safeHTML } from './safe-html'; -export { default as isSelectionForward } from './is-selection-forward';