From 710347c12eb61b31fd3e2d6e5da90238fac346a8 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Fri, 10 May 2024 14:28:31 +0200 Subject: [PATCH 1/2] Fix labeling of the RSS block placeholder. --- packages/block-library/src/rss/edit.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/packages/block-library/src/rss/edit.js b/packages/block-library/src/rss/edit.js index 7c35d63f4fc894..ff1a9bd81ee87a 100644 --- a/packages/block-library/src/rss/edit.js +++ b/packages/block-library/src/rss/edit.js @@ -59,10 +59,18 @@ export default function RSSEdit( { attributes, setAttributes } ) { const blockProps = useBlockProps(); + const label = __( 'RSS URL' ); + if ( isEditing ) { return (
- +
@@ -82,7 +92,7 @@ export default function RSSEdit( { attributes, setAttributes } ) { variant="primary" type="submit" > - { __( 'Use URL' ) } + { __( 'Apply' ) } From b6b9a5a64fe030030012afa17c3293f8f42c3102 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Fri, 10 May 2024 15:03:55 +0200 Subject: [PATCH 2/2] Fix RSS placeholder spacing. --- packages/block-library/src/rss/edit.js | 39 ++++++++++------------ packages/block-library/src/rss/editor.scss | 4 +-- 2 files changed, 20 insertions(+), 23 deletions(-) diff --git a/packages/block-library/src/rss/edit.js b/packages/block-library/src/rss/edit.js index ff1a9bd81ee87a..467b22e3e58835 100644 --- a/packages/block-library/src/rss/edit.js +++ b/packages/block-library/src/rss/edit.js @@ -14,7 +14,6 @@ import { RangeControl, ToggleControl, ToolbarGroup, - __experimentalHStack as HStack, __experimentalInputControl as InputControl, } from '@wordpress/components'; import { useState } from '@wordpress/element'; @@ -75,26 +74,24 @@ export default function RSSEdit( { attributes, setAttributes } ) { onSubmit={ onSubmitURL } className="wp-block-rss__placeholder-form" > - - - setAttributes( { feedURL: value } ) - } - className="wp-block-rss__placeholder-input" - /> - - + + setAttributes( { feedURL: value } ) + } + className="wp-block-rss__placeholder-input" + /> +
diff --git a/packages/block-library/src/rss/editor.scss b/packages/block-library/src/rss/editor.scss index 9b4bac2874ad5b..095da46973509d 100644 --- a/packages/block-library/src/rss/editor.scss +++ b/packages/block-library/src/rss/editor.scss @@ -14,8 +14,8 @@ } .wp-block-rss__placeholder-input { - flex: 1; - min-width: 80%; + margin: 0 8px 0 0; + flex: 1 1 auto; } }