Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontSizePicker: add "label" and "help" properties #68551

Open
slaFFik opened this issue Jan 8, 2025 · 3 comments · May be fixed by #68557
Open

FontSizePicker: add "label" and "help" properties #68551

slaFFik opened this issue Jan 8, 2025 · 3 comments · May be fixed by #68557
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@slaFFik
Copy link

slaFFik commented Jan 8, 2025

What problem does this address?

By default, FontSizePicker component has a "Size" label, and no "help" text, as pictured:
Image

The component does not support label property, like TextareaControl, and no help too.

I would like to be able to describe to users which size this control is controlling. Depending on the application, there can be "internal" font size, "external" font size, smart tag font-size (which is rendering smart tags values in a different font sizes due to a different "weight" of that text), etc.

What is your proposed solution?

I propose to add support for these properties so developers can provide additional context.

@slaFFik slaFFik added the [Type] Enhancement A suggestion for improvement. label Jan 8, 2025
@slaFFik
Copy link
Author

slaFFik commented Jan 8, 2025

Realistically the same for the FontFamilyControl component too. Should I create a separate issue?

@slaFFik
Copy link
Author

slaFFik commented Jan 8, 2025

The workaround is to wrap in BaseControl component which does have help and label.

@SainathPoojary
Copy link
Contributor

Thanks for raising the issue, @slaFFik . I’d like to work on this.

@SainathPoojary SainathPoojary linked a pull request Jan 9, 2025 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants