-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row block should provide option for mobile responsive like columns block #68433
Comments
Thanks for raising the issue, Screen.Recording.2024-12-31.at.3.47.14.PM.mov |
The "Allow to wrap to multiple lines" option should allow you to achieve a similar effect. The Columns block predates modern CSS layouts like Flex and Grid. That's one of the reasons it has a unique "Stack on Mobile" setting. TL;DR: Row and Grid blocks shouldn't mimic the Columns block but instead embrace the capabilities of modern CSS layouts. Screenshot |
Hello @Mamaduka |
@rinkalpagdar @Rishit30G I’d like to work on this. I’ll have a draft PR ready and open in a few minutes. |
@Mayank-Tripathi32, let's wait for more feedback before starting PR for this. |
I think Adding the "Stack on Mobile" option feels like a temporary fix. Perhaps instead of discussing a specific block, we should look at the broader picture and find the ideal solution? There have been many requests for a responsive option, and I think the following issues are similar to this one:
It may be best to close this issue and continue the discussion in the above issues. P.S. It's worth checking out the responsive tools, one of the upcoming features mentioned in the State of the Word 2024. There, a demo shows how we can set block settings and block styles for each device preview (breakpoint). It's mentioned at the 28-minute 59-second mark. https://www.youtube.com/watch?v=KLybH5YvIPQ&t=1739s |
I know, off-topic, but was this anywhere discussed beforehand? Matias makes pretty big (and specific) promises here - I may have missed a proposal on Make or elsewhere… |
Description
Row block should provide option to "Stack on mobile" just like columns, because currently row block cause overflow on mobile devices if "Allow to wrap to multiple lines" is not enabled.
Step-by-step reproduction instructions
Expected behaviour
It should have a "stack on mobile" option like the columns block.
Screenshots or screen recording (optional)
row-block-mobile-issue.mp4
Environment
The text was updated successfully, but these errors were encountered: