Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin block support to the core/query-pagination block. #68428

Open
daviedR opened this issue Dec 31, 2024 · 0 comments · May be fixed by #68429
Open

Add margin block support to the core/query-pagination block. #68428

daviedR opened this issue Dec 31, 2024 · 0 comments · May be fixed by #68429
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@daviedR
Copy link
Contributor

daviedR commented Dec 31, 2024

What problem does this address?

When designing a query layout, designers might want to give a space between the Post Template (core/post-template) and Pagination (core/query-pagination). This space should not be persistent, because pagination is situational and might not be rendered depending on the query results. Using a Spacer block is imperfect because the space block is still there even when the pagination is not rendered.

A possible workaround is to wrap the Post Template and Pagination block into a Group (core/group) block and give the group a block spacing. This will add space between the Post Template and the Pagination block. It works on the front end, but somehow the block spacing doesn't appear in the editor. Bug?

What is your proposed solution?

Add margin support to the Pagination block, so the space can be added to the Pagination block and not persistent. When the query doesn't render pagination, there is no unneeded extra space after the Post Template block.

@daviedR daviedR added the [Type] Enhancement A suggestion for improvement. label Dec 31, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 31, 2024
@t-hamano t-hamano added the [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants