Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Document when "rest props" are passed down to underlying element/component #67979

Open
mirka opened this issue Dec 13, 2024 · 1 comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers

Comments

@mirka
Copy link
Member

mirka commented Dec 13, 2024

What problem does this address?

A lot of our components pass down any "rest props" to an internal element or component. Our TypeScript annotations reflect this accurately, but we don't usually mention it in the docs (e.g. Storybook). It would be good to note these explicitly.

What is your proposed solution?

Ideally we figure out a way present this information systematically in both the Storybook and README docs. At minimum, the information should be available in the Storybook docs.

It should say something like "Any other props will be passed down to the underlying foo element" (or Foo component).

@Vrishabhsk
Copy link
Contributor

Hi @mirka 👋

Let me know your thoughts on this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

No branches or pull requests

2 participants