Replace Star Icon with Pin Icon for 'Pin to Toolbar'

[jayclydeTags]

Currently, the 'Pin to Toolbar' feature uses a star icon to represent pinning a Comment in this case.

I propose using a pin icon instead, as it more accurately represents the action of pinning.

• A pin icon is a more widely recognized symbol for pinning items.
• It would provide a more intuitive user experience.

[jayclydeTags]

also remove the extra space here:

[Mamaduka]

cc @WordPress/gutenberg-design

[jasmussen]

The extra space definitely seems like a regression.

Pinning and unpinning seems broken in a few ways for the moment: every single item that can be pinned, should also have an item in the "More" menu, otherwise you can't open it on mobile. That doesn't seem part of the API at the moment, where it seems arbitrary whether a sidebar honors this or not.

As far as star or pin, I'd still go with star for now. There's a larger question about pinning and unpinning that seems more important to fix in the near term, some larger pieces to improve, so just changing the star isn't going to fix that.

[t-hamano]

Regarding the extra space, it was fixed in #66677.

[Mamaduka]

Thanks, @t-hamano!

In that case, we can close this issue. As @jasmussen pointed out, changing the Star to Pin icon doesn't improve UX.