Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site editor: iterate on site icon animation #65428

Closed
annezazu opened this issue Sep 18, 2024 · 2 comments · Fixed by #65497
Closed

Site editor: iterate on site icon animation #65428

annezazu opened this issue Sep 18, 2024 · 2 comments · Fixed by #65497
Assignees
@jameskoster
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 18, 2024 •
edited
Loading

While this initial PR landed to try to clarify that the site icon is a back button, I think it's missing the mark and looks more broken than anything else. @WordPress/gutenberg-design can we iterate here? I think we can do better for 6.7. At the least, I think we should revert to what was there before. If we can, we should iterate.

gray.box.mov
@annezazu annezazu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 18, 2024
@paaljoachim
Copy link
Contributor

This looks like a bug. As something similar shows up example when there is a missing icon when using FontAwesome.
Hover top left site logo in Site Editor

@jameskoster jameskoster mentioned this issue Sep 19, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 19, 2024
@afercia
Copy link
Contributor

afercia commented Sep 20, 2024

I'd totally agree, see my previous comment at #64161 (comment)

Still the entire mechanism of going back and exiting the editor is unclear and needs some rethinking together with the meaning and usage of the WP logo / Site Icon preview. See #57813

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Sep 20, 2024
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.7 Editor Tasks Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskoster jameskoster

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
WordPress 6.7 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update icon in home button WordPress/gutenberg
4 participants
@jameskoster @afercia @paaljoachim @annezazu