Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the Site card in the pre-publish checks #65365

Open
2 tasks done
afercia opened this issue Sep 16, 2024 · 1 comment
Open
2 tasks done

Reconsider the Site card in the pre-publish checks #65365

afercia opened this issue Sep 16, 2024 · 1 comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor

Comments

@afercia
Copy link
Contributor

afercia commented Sep 16, 2024

Description

When publishing a post and the pre-publish checks are enabled (it's the default setting), the pre-publish checks panel shows a 'site card' with some information related to the site:

  • Site icon, if any. Notice that this isn't the site logo. It's the site icon.
  • Site title.
  • Site home URL.

Screenshot:

02

I'm not sure I understand why these information are shown in the publish flow.

Conceptually, this panel is about checking the details of the post before publishing. However, these infos are about the site. As a user, I don't need to check these site infos each time I publish a post.

Typically, the site icon, site title, and site home URL are settings that users set once and then 'forget', as in: it's very rare to have to edit these settings. Instead, these settings are shown each time I publish a post. Why?

Also, these settings cannot be edited in the pre-publish panel, which defeats the whole purpose of this panel: checking important details and have the last chance to edit them before publishing. Anyways, these settings are site-related and shouldn't be displayed in a panel that is supposed to show post-related information.

As a user, I'd rather need to check other important information before publishing a post. Most notably, I need to check the post permalink and have the chance to edit the slug.

In the screenshot below, the three steps for publishing a post when the pre-publish checks are enabled:

01

  1. The Post tab in the Settings panel is the only place that exposes the permalink UI. However, the Settings panel may be closed or a block may be selected so that the Settings panel shows the 'Block' tab and the permalink UI wouldn't be shown in that case.
  2. In the pre-publish checks the permalink and slug values disappear. In stead, it shows the Site card data, which I'm arguing is any useful in the publish flow.
  3. Finally, in the post-publish panel the permalink and slug values appear again. But it's to0 late to edit the slug before publishing.

See also related #61196 for the greatly inconsistent terminology used in these panels: link, address, permalink, slug, etc.

Step-by-step reproduction instructions

  • Make sure the pre-publish check preferences is enabled.
  • Publish a post.
  • Observe the pre-publish panel shows the Site card with unnecessary information about the site.
  • Observe the pre-publish panel does not show the UI to view and edit the permalink / slug.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor labels Sep 16, 2024
@iamleese
Copy link

I agree, the site card doesn't need to be there at all. The pre-publish check should be page- or post-related. It would be more useful to have an editable permalink to match the Page or Post tab.

@mtias mtias removed the [Type] Bug An existing feature does not function as intended label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor
Projects
None yet
Development

No branches or pull requests

3 participants