Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat-x and repeat-y options to background images #62608

Open
jordesign opened this issue Jun 17, 2024 · 3 comments
Open

Add repeat-x and repeat-y options to background images #62608

jordesign opened this issue Jun 17, 2024 · 3 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jordesign
Copy link
Contributor

Currently it is possible to set 'repeat' on background images (assigned to blocks). It would be good to be able to select repeat-x or repeat-y as well for greater control

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 17, 2024
@t-hamano
Copy link
Contributor

I think this is a great suggestion.

However, since the backgroud-repeat property can use four properties, repeat, no-repeat, space, and round, I think we need to consider how much support we need to provide.

I would like to suggest some design ideas.

If all values ​​are supported

Use ToggleGroupControl

full-suport_1

Use SelectControl

full-support_2

If only repeat and no-repeat are supported

Use ToggleGroupControl

repeat-1

Use ToggleControl

repeat-2

Use SelectControl

repeat-3

cc @ramonjd @WordPress/gutenberg-design

@t-hamano t-hamano added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json and removed [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 17, 2024
@andrewserong andrewserong added the Needs Design Feedback Needs general design feedback. label Jun 17, 2024
@ramonjd
Copy link
Member

ramonjd commented Jun 17, 2024

Thanks for the issue.

I think @t-hamano is right - most of the heavy thinking on adding support will be how to present the design tools. 👍🏻

I'll also add this issue tentatively to the tracking issue.

@jameskoster
Copy link
Contributor

I would lean towards the SelectControl design (with the addition of a 'None' option) to begin with. round and space seem very niche to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Status: Next
Development

No branches or pull requests

5 participants