Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site editor: Allow on-the-fly device preview customization #37419

Open
zaguiini opened this issue Dec 15, 2021 · 3 comments
Open

Site editor: Allow on-the-fly device preview customization #37419

zaguiini opened this issue Dec 15, 2021 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Feature New feature to highlight in changelogs.

Comments

@zaguiini
Copy link
Member

What problem does this address?

We're using two fixed-width device preview dimensions (tablet and mobile) and a wide one (desktop).

When on desktop, resizing the window reflects the dimension change immediately.

However, tablet and mobile don't have such controls, but we have multiple screen dimensions for them, and having a fixed one doesn't have much.

What is your proposed solution?

Allow on-the-fly device preview width changes, just like we have on the Responsive tool in the Chrome Developer menu.

It shouldn't be hard to implement that in Gutenberg since we actually have the mechanisms already: drag and drop width, just like on isolated template part view.
@talldan
Copy link
Contributor

talldan commented Dec 16, 2021

@zaguiini Is this for the site editor? The post editor does have a similar feature, but I don't think the breakpoints are customizable (as requested in #21235).

@talldan talldan added the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 16, 2021
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jan 1, 2022
@zaguiini
Copy link
Member Author

zaguiini commented Jan 4, 2022

Yes, @talldan. The request is specifically for the site editor.

@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jan 4, 2022
@talldan talldan added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feature New feature to highlight in changelogs. and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Jan 10, 2022
@talldan talldan changed the title Allow on-the-fly device preview customization Site editor: Allow on-the-fly device preview customization Jan 10, 2022
@talldan talldan added Needs Design Needs design efforts. Needs Design Feedback Needs general design feedback. labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@talldan @zaguiini