Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the columns number input kills the content #15525

Closed
draganescu opened this issue May 9, 2019 · 4 comments
Closed

Modifying the columns number input kills the content #15525

draganescu opened this issue May 9, 2019 · 4 comments
Labels
[Block] Columns Affects the Columns Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Describe the bug
When we alter the number of columns using the input instead of the slider the content is not saved.

To reproduce
Steps to reproduce the behavior:

  1. In a post or page
  2. Add a column block
  3. Write some text in both blocks
  4. Select the columns block
  5. Modify the number of columns in the inspector by changing the number in the input, instead of the slider, e.g. instead of 2, delete 2 and write 3
  6. Content is gone.

Expected behavior
To behave like the slider:

  • If I am adding columns the content remains
  • If I am removing the content is deleted RTL
  • If I add the same number the content is saved

Screenshots

collumns-no-content

@draganescu draganescu added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended labels May 9, 2019
@youknowriad
Copy link
Contributor

This is related to #9009 while not exactly the same thing, I think they should have a unique solution. Would you mind adding details to that issue.

@draganescu
Copy link
Contributor Author

@youknowriad I'll add there, but that problem (#9009) is about adding rows to columns, while this looks like a bug in handling that number input, a much smaller issue I'd say, right?

@youknowriad
Copy link
Contributor

yes, smaller one but if the fix for the other issue is to avoid the "input" and use buttons to add/remove columns, this will be fixed automatically. I don't mind reopening this issue but it feels like the solution could fix both

@draganescu
Copy link
Contributor Author

good point on removing the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants