Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing Number of Columns Deletes Content #12665

Closed
mrwweb opened this issue Dec 7, 2018 · 3 comments
Closed

Reducing Number of Columns Deletes Content #12665

mrwweb opened this issue Dec 7, 2018 · 3 comments
Labels
[Block] Columns Affects the Columns Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@mrwweb
Copy link

mrwweb commented Dec 7, 2018

Describe the bug
When creating multiple columns and then reducing the number of columns by one or more, the blocks in the removed columns are lost.

To Reproduce

  1. Add a columns block of 3 or more
  2. Fill in all the columns with content
  3. Reduce the number of blocks (right column disappears)
  4. Increase the number of blocks (right column is empty)

Note: The content is recoverable using undo, though there's a smaller bug where the addition/removal of the column and the incrementing of the column number setting textbox are two separate steps of undoing.

Expected behavior
I know that the current behavior is not what I expect, but I could see a variety of acceptable behaviors.

  1. My initial expectation was that the columns would act as a grid. i.e. I have 4 columns of content. If I reduce the columns to 3, I will have one row of 3 column and 1 row of one column. When I later showed this bug to a fellow WordPress user he independently shared the same expectation when I asked him what he expected to happen before I reduced the number of columns.
  2. A second thought was that the removed column might simply just be removed from the columns and placed directly in the body below the columns block. This might be a little weird but would avoid the data loss.
  3. A warning that I am about to lose data. Possibly provide the option to place the lost blocks below the columns or confirm deletion.

Screenshots
animated GIF showing steps to reproduce

Desktop (please complete the following information):
Win 10, Firefox 63.0.3, WordPress 5.0, no plugins, Twenty Nineteen

@danielbachhuber danielbachhuber added [Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement. labels Dec 7, 2018
@danielbachhuber danielbachhuber added this to the Future: 5.1 milestone Dec 7, 2018
@danielbachhuber danielbachhuber added the Needs Decision Needs a decision to be actionable or relevant label Dec 7, 2018
@youknowriad youknowriad added Needs Design Needs design efforts. and removed Needs Decision Needs a decision to be actionable or relevant labels Dec 25, 2018
@youknowriad
Copy link
Contributor

I think this needs to be improved design-wise. Ideally removing a column is an explicit action (clicking a "x" or something like that) instead of a range input.

@msdesign21
Copy link

Related: #9009

@youknowriad
Copy link
Contributor

Thanks @msdesign21 Let's close as a duplicate of #9009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants