From fd97afccde43da4d5a55a24cb6bf08bb4ef220b9 Mon Sep 17 00:00:00 2001 From: Adam Silverstein Date: Fri, 31 Jan 2025 08:00:26 -0700 Subject: [PATCH] Revert "Only show "No items found" when isLoading is false" This reverts commit 76488c1841a4932a3350c927ea739c4da4b5bbfd. --- packages/components/src/combobox-control/index.tsx | 1 - packages/components/src/form-token-field/index.tsx | 2 -- .../components/src/form-token-field/suggestions-list.tsx | 3 +-- packages/components/src/form-token-field/types.ts | 6 ------ 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/packages/components/src/combobox-control/index.tsx b/packages/components/src/combobox-control/index.tsx index fe0b6aaad30b58..33276ed0823f86 100644 --- a/packages/components/src/combobox-control/index.tsx +++ b/packages/components/src/combobox-control/index.tsx @@ -399,7 +399,6 @@ function ComboboxControl( props: ComboboxControlProps ) { __experimentalRenderItem={ __experimentalRenderItem } - isLoading={ isLoading } /> ) } diff --git a/packages/components/src/form-token-field/index.tsx b/packages/components/src/form-token-field/index.tsx index 95af52fa21ffd5..987c75d769b727 100644 --- a/packages/components/src/form-token-field/index.tsx +++ b/packages/components/src/form-token-field/index.tsx @@ -77,7 +77,6 @@ export function FormTokenField( props: FormTokenFieldProps ) { __experimentalAutoSelectFirstMatch = false, __nextHasNoMarginBottom = false, tokenizeOnBlur = false, - isLoading = false, } = useDeprecated36pxDefaultSizeProp< FormTokenFieldProps >( props ); if ( ! __nextHasNoMarginBottom ) { @@ -744,7 +743,6 @@ export function FormTokenField( props: FormTokenFieldProps ) { onHover={ onSuggestionHovered } onSelect={ onSuggestionSelected } __experimentalRenderItem={ __experimentalRenderItem } - isLoading={ isLoading } /> ) } diff --git a/packages/components/src/form-token-field/suggestions-list.tsx b/packages/components/src/form-token-field/suggestions-list.tsx index bd073026666d30..1339e0cc189e38 100644 --- a/packages/components/src/form-token-field/suggestions-list.tsx +++ b/packages/components/src/form-token-field/suggestions-list.tsx @@ -31,7 +31,6 @@ export function SuggestionsList< suggestions = [], displayTransform, instanceId, - isLoading, __experimentalRenderItem, }: SuggestionsListProps< T > ) { const listRef = useRefEffect< HTMLUListElement >( @@ -158,7 +157,7 @@ export function SuggestionsList< ); /* eslint-enable jsx-a11y/click-events-have-key-events */ } ) } - { suggestions.length === 0 && ! isLoading && ( + { suggestions.length === 0 && (
  • { __( 'No items found' ) }
  • diff --git a/packages/components/src/form-token-field/types.ts b/packages/components/src/form-token-field/types.ts index 989a5611149a0e..051f00a6cdeb06 100644 --- a/packages/components/src/form-token-field/types.ts +++ b/packages/components/src/form-token-field/types.ts @@ -190,11 +190,6 @@ export interface FormTokenFieldProps * @default false */ tokenizeOnBlur?: boolean; - - /** - * Is the component loading data? - */ - isLoading?: boolean; } /** @@ -212,7 +207,6 @@ export interface SuggestionsListProps< displayTransform: ( value: T ) => string; instanceId: string | number; __experimentalRenderItem?: ( args: { item: T } ) => ReactNode; - isLoading?: boolean; } export interface TokenProps extends TokenItem {