From ceb13e23c3e2db04e4ed0e10d5d256b0e26e0aea Mon Sep 17 00:00:00 2001 From: im3dabasia Date: Fri, 28 Feb 2025 14:22:23 +0530 Subject: [PATCH] fix: Wrong import group for router/, core-data/, editor/ --- packages/core-data/src/selectors.ts | 2 +- .../src/page-utils/drag-files.ts | 2 +- .../src/components/offline-status/test/index.native.js | 2 +- .../editor/src/components/preview-dropdown/index.js | 2 +- packages/editor/src/private-apis.js | 10 +++++----- packages/router/src/router.tsx | 6 +----- 6 files changed, 10 insertions(+), 14 deletions(-) diff --git a/packages/core-data/src/selectors.ts b/packages/core-data/src/selectors.ts index 64ff340afd0c2..4d2fe832f7fad 100644 --- a/packages/core-data/src/selectors.ts +++ b/packages/core-data/src/selectors.ts @@ -4,6 +4,7 @@ import { createSelector, createRegistrySelector } from '@wordpress/data'; import { addQueryArgs } from '@wordpress/url'; import deprecated from '@wordpress/deprecated'; +import type { UndoManager } from '@wordpress/undo-manager'; /** * Internal dependencies @@ -23,7 +24,6 @@ import { getUserPermissionCacheKey, } from './utils'; import type * as ET from './entity-types'; -import type { UndoManager } from '@wordpress/undo-manager'; // This is an incomplete, high-level approximation of the State type. // It makes the selectors slightly more safe, but is intended to evolve diff --git a/packages/e2e-test-utils-playwright/src/page-utils/drag-files.ts b/packages/e2e-test-utils-playwright/src/page-utils/drag-files.ts index d0af0b499f286..7155890ec8d80 100644 --- a/packages/e2e-test-utils-playwright/src/page-utils/drag-files.ts +++ b/packages/e2e-test-utils-playwright/src/page-utils/drag-files.ts @@ -4,12 +4,12 @@ import { readFile } from 'fs/promises'; import { basename } from 'path'; import { getType } from 'mime'; +import type { Locator } from '@playwright/test'; /** * Internal dependencies */ import type { PageUtils } from './index'; -import type { Locator } from '@playwright/test'; type FileObject = { name: string; diff --git a/packages/editor/src/components/offline-status/test/index.native.js b/packages/editor/src/components/offline-status/test/index.native.js index 7e8787c4033b0..fd717b5508ee1 100644 --- a/packages/editor/src/components/offline-status/test/index.native.js +++ b/packages/editor/src/components/offline-status/test/index.native.js @@ -2,6 +2,7 @@ * External dependencies */ import { act, render, screen } from 'test/helpers'; +import { AccessibilityInfo } from 'react-native'; /** * WordPress dependencies @@ -15,7 +16,6 @@ import { * Internal dependencies */ import OfflineStatus from '../index'; -import { AccessibilityInfo } from 'react-native'; jest.mock( '../style.native.scss', () => ( { 'offline--icon': { diff --git a/packages/editor/src/components/preview-dropdown/index.js b/packages/editor/src/components/preview-dropdown/index.js index 3fa1e211bb7d3..97b05f13972b8 100644 --- a/packages/editor/src/components/preview-dropdown/index.js +++ b/packages/editor/src/components/preview-dropdown/index.js @@ -21,12 +21,12 @@ import { useSelect, useDispatch } from '@wordpress/data'; import { store as coreStore } from '@wordpress/core-data'; import { store as preferencesStore } from '@wordpress/preferences'; import { ActionItem } from '@wordpress/interface'; +import { store as blockEditorStore } from '@wordpress/block-editor'; /** * Internal dependencies */ import { store as editorStore } from '../../store'; -import { store as blockEditorStore } from '@wordpress/block-editor'; import PostPreviewButton from '../post-preview-button'; import { unlock } from '../../lock-unlock'; diff --git a/packages/editor/src/private-apis.js b/packages/editor/src/private-apis.js index e064c73b0ae63..b935a5e07cd19 100644 --- a/packages/editor/src/private-apis.js +++ b/packages/editor/src/private-apis.js @@ -2,6 +2,11 @@ * WordPress dependencies */ import * as interfaceApis from '@wordpress/interface'; +import { + CreateTemplatePartModal, + patternTitleField, + templateTitleField, +} from '@wordpress/fields'; /** * Internal dependencies @@ -23,11 +28,6 @@ import { mergeBaseAndUserConfigs, GlobalStylesProvider, } from './components/global-styles-provider'; -import { - CreateTemplatePartModal, - patternTitleField, - templateTitleField, -} from '@wordpress/fields'; import { registerCoreBlockBindingsSources } from './bindings/api'; import { getTemplateInfo } from './utils/get-template-info'; diff --git a/packages/router/src/router.tsx b/packages/router/src/router.tsx index 8ad54e9264678..3aff41d81c8fb 100644 --- a/packages/router/src/router.tsx +++ b/packages/router/src/router.tsx @@ -3,6 +3,7 @@ */ import RouteRecognizer from 'route-recognizer'; import { createBrowserHistory } from 'history'; +import type { ReactNode } from 'react'; /** * WordPress dependencies @@ -21,11 +22,6 @@ import { } from '@wordpress/url'; import { useEvent } from '@wordpress/compose'; -/** - * Internal dependencies - */ -import type { ReactNode } from 'react'; - const history = createBrowserHistory(); interface Route { name: string;