From 0c216f100379f222419543cfebf1fc197333848d Mon Sep 17 00:00:00 2001 From: Mario Santos <34552881+SantosGuillamot@users.noreply.github.com> Date: Wed, 24 Jan 2024 21:02:34 +0100 Subject: [PATCH] Block Bindings: Fix button popover not showing in patterns (#58219) * Use `lockUrlControls` variable in button * Add `linkTarget` to JS allowed blocks object --- packages/block-editor/src/hooks/use-bindings-attributes.js | 2 +- packages/block-library/src/button/edit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/block-editor/src/hooks/use-bindings-attributes.js b/packages/block-editor/src/hooks/use-bindings-attributes.js index 6f669f1a321c22..94aac654097e5d 100644 --- a/packages/block-editor/src/hooks/use-bindings-attributes.js +++ b/packages/block-editor/src/hooks/use-bindings-attributes.js @@ -26,7 +26,7 @@ const BLOCK_BINDINGS_ALLOWED_BLOCKS = { 'core/paragraph': [ 'content' ], 'core/heading': [ 'content' ], 'core/image': [ 'url', 'title', 'alt' ], - 'core/button': [ 'url', 'text' ], + 'core/button': [ 'url', 'text', 'linkTarget' ], }; const createEditFunctionWithBindingsAttribute = () => diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js index f6e465786ef69e..7dffdfb5c1b669 100644 --- a/packages/block-library/src/button/edit.js +++ b/packages/block-library/src/button/edit.js @@ -336,7 +336,7 @@ function ButtonEdit( props ) { { isLinkTag && isSelected && ( isEditingURL || isURLSet ) && - ! metadata?.bindings?.url && ( + ! lockUrlControls && ( {