[BUG]: config-at-startup triggering unnecessary reboots

[joshschmelzle]

What happened?

M4+ is adding multiple reboots during a legitimate reboot for no reason. Power cycling by physically unplugging and plugging in PoE, with no USB cable connect, the startup script is hitting some race condition triggering multiple subsequent reboots. Unacceptable user experience.

There are multiple potential issues and logic flaws I see in the code. We also need to log by default somewhere reboot reasons. We cannot expect users to enable some debug and then reproduce the issue again to understand what is going on.

Relevant log output

Jan 24 16:17:48 wlanpi-573 wlanpi-config-at-startup.sh[495]: Applying WLAN Pi M4+ settings
Jan 24 16:17:53 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Succeeded.
Jan 24 16:35:27 wlanpi-573 sudo[9238]:   wlanpi : TTY=pts/0 ; PWD=/home/wlanpi ; USER=root ; COMMAND=/usr/bin/vim /opt/wlanpi-common/wlanpi-config-at-startup.sh
Jan 24 16:35:39 wlanpi-573 sudo[9766]:   wlanpi : TTY=pts/0 ; PWD=/home/wlanpi ; USER=root ; COMMAND=/usr/bin/vim /opt/wlanpi-common/wlanpi-config-at-startup.sh
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Detected WLAN Pi board: Mcuzone M4+
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Applying WLAN Pi M4+ settings
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Waveshare file already exists, no action needed
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Fan controller is already disabled, no action needed
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: RTC is already disabled, no action needed
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Battery gauge is already disabled, no action needed
Jan 24 16:35:56 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Detected 1 line in lsusb output
Jan 24 16:36:01 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: OTG link isn't operational
Jan 24 16:36:01 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Host mode is enabled in configuration but isn't working
Jan 24 16:36:01 wlanpi-573 wlanpi-config-at-startup.sh[492]: Debugger: Switching to OTG mode and rebooting now
Jan 24 16:36:01 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Main process exited, code=killed, status=15/TERM
Jan 24 16:36:01 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Failed with result 'signal'.
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Detected WLAN Pi board: Mcuzone M4+
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Applying WLAN Pi M4+ settings
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Waveshare file already exists, no action needed
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Fan controller is already disabled, no action needed
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: RTC is already disabled, no action needed
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Battery gauge is already disabled, no action needed
Jan 24 16:36:16 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Detected 1 line in lsusb output
Jan 24 16:36:21 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: OTG link isn't operational
Jan 24 16:36:21 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: OTG mode is enabled in configuration but isn't working
Jan 24 16:36:21 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Switching to host mode and rebooting now
Jan 24 16:36:21 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Uncommenting otg_mode=1 to enable host mode
Jan 24 16:36:21 wlanpi-573 wlanpi-config-at-startup.sh[503]: Debugger: Creating force host mode file
Jan 24 16:36:22 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Main process exited, code=killed, status=15/TERM
Jan 24 16:36:22 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Failed with result 'signal'.
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Detected WLAN Pi board: Mcuzone M4+
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Applying WLAN Pi M4+ settings
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Waveshare file already exists, no action needed
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Fan controller is already disabled, no action needed
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: RTC is already disabled, no action needed
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Battery gauge is already disabled, no action needed
Jan 24 16:36:35 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Detected 1 line in lsusb output
Jan 24 16:36:40 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: OTG link isn't operational
Jan 24 16:36:40 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Host mode is enabled in configuration but isn't working
Jan 24 16:36:40 wlanpi-573 wlanpi-config-at-startup.sh[494]: Debugger: Staying in host mode and removing force host mode file
Jan 24 16:36:40 wlanpi-573 systemd[1]: wlanpi-config-at-startup.service: Succeeded.

How often does this bug happen?

Every time

What version are you using?

M4+, classic, 3.2.3

Self Service

• I would be willing to fix this bug myself.

Guidelines and Policies

• I have read the contributing guidelines and agree to follow the code of conduct and contribution policies.