diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index fb4cf5f3..561ee980 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -49,11 +49,13 @@ jobs: run: bundle install - name: Get test project semver id: get_semver + shell: bash run: | semver=$(ruby echo_client_spec_version.rb) echo "::set-output name=semver::$semver" - name: Download test cases run: git clone --depth 5 --branch v${{ steps.get_semver.outputs.semver }} https://github.com/Unleash/client-specification.git client-specification + shell: bash - name: Run tests run: bundle exec rake env: diff --git a/spec/unleash/client_specification_spec.rb b/spec/unleash/client_specification_spec.rb index 552f277f..ff207a64 100644 --- a/spec/unleash/client_specification_spec.rb +++ b/spec/unleash/client_specification_spec.rb @@ -24,7 +24,8 @@ JSON.parse(File.read(SPECIFICATION_PATH + '/index.json')).each do |test_file| describe "for #{test_file}" do - current_test_set = JSON.parse(File.read(SPECIFICATION_PATH + '/' + test_file)) + ## Encoding is set in this read purely for JRuby. Don't take this out, it'll work locally and then fail on CI + current_test_set = JSON.parse(File.read(SPECIFICATION_PATH + '/' + test_file, encoding: 'utf-8')) context "with #{current_test_set.fetch('name')} " do tests = current_test_set.fetch('tests', []) tests.each do |test| diff --git a/unleash-client.gemspec b/unleash-client.gemspec index 32857318..51dd2af8 100644 --- a/unleash-client.gemspec +++ b/unleash-client.gemspec @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| spec.require_paths = ["lib"] spec.required_ruby_version = ">= 2.7" - spec.add_dependency "yggdrasil-engine", "~> 0.0.9" + spec.add_dependency "yggdrasil-engine", "~> 1.0.1" spec.add_development_dependency "bundler", "~> 2.1" spec.add_development_dependency "rake", "~> 12.3"