Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do profiling for mode_appt_constraints = 2 too #1334

Open
marghe-molaro opened this issue May 10, 2024 · 2 comments
Open

Do profiling for mode_appt_constraints = 2 too #1334

marghe-molaro opened this issue May 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@marghe-molaro
Copy link
Collaborator

Perform profiling in #286 for mode_appt_constraints = 2 too

@tbhallett tbhallett added the enhancement New feature or request label May 17, 2024
@willGraham01
Copy link
Collaborator

Hi @marghe-molaro - for this issue do you mean to produce SnakeViz plots like those in #286 for mode=2 automatically, or just as a one-off? If a one-off, I can set a run off this week and post the output here.

At present, the profiling workflow that runs weekly is running in mode 2 (http://github-pages.ucl.ac.uk/TLOmodel-profiling/profiling.html) and it outputs information about time spent in each function like this. This organises time spent in each function by the call-stack, rather than pooling the time in each function like in the plots of #286.

If you think it would be useful to produce such plots as part of the automated workflow (that gets published to the profiling page), just say so and I can look into it.

@marghe-molaro
Copy link
Collaborator Author

Hi @willGraham01, ideally as we move to mode=2 being used as frequently as mode=1 we'd have the entire profiling framework applied to mode=1 being applied to mode=2 also, and just as frequently. The issue though is one of resources being limited - both to do the profiling runs and to analyse/optimise the code based on those outputs - so I think how many of the available resources should be allocated to the mode=1 vs =2 analysis is one for @tbhallett to answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants