Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Polygon With Holes in Dynmap/BlueMap #23

Open
silverwolfg11 opened this issue Apr 3, 2022 · 5 comments
Open

Display Polygon With Holes in Dynmap/BlueMap #23

silverwolfg11 opened this issue Apr 3, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@silverwolfg11
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, MapTowny does not display a polygon with holes on Dynmap or BlueMap, but does display it for other web-map plugins. This makes claims rendered inaccurate since the rendered claim fills in the holes of the polygon.

Describe the solution you'd like
The holes in the polygon will not be filled in on BlueMap or Dynmap.

Describe alternatives you've considered
N/A

Additional context
Some great ideas on how to approach this were provided by PolitcubesDeveloper:
#22 (comment)

@silverwolfg11 silverwolfg11 added the enhancement New feature or request label Apr 3, 2022
@ItsJuls
Copy link

ItsJuls commented Aug 7, 2022

Anything from this?

@ItsJuls
Copy link

ItsJuls commented Aug 28, 2022

https://github.com/Chicken/BlueMap-Towny/ has holes for wilderness chunks, might be useful

@silverwolfg11
Copy link
Collaborator Author

silverwolfg11 commented Sep 5, 2022

https://github.com/Chicken/BlueMap-Towny/ has holes for wilderness chunks, might be useful

That plugin seems to use this file with algorithms for achieving holes in wilderness. I haven't had time to look into those algorithms, but I'm sure it would be possible to adapt them for MapTowny. If anyone wants to take a shot at it and PR it to MapTowny, that would be heavily appreciated.

That code is licensed under GPL v3 and integrating it into the project is a little tricky. I would have to make MapTowny mostly MIT, and include a GPL portion. Since IANAL, I have no idea if that is even something I could do or if I need to do anything extra to make the project follow proper licensing.

In terms of a sort of ETA on this, it will definitely be a while. I currently want to work on mapping the town blocks like Dynmap-Towny does so that both plugins can be at feature parity with each other. Then I would take a look at this.

@illuziator
Copy link

That plugin seems to use this file

regions with holes are divided into segments using breadth-first search and the border-line is drawn separately.

@silverwolfg11 silverwolfg11 added this to the 3.0.0 milestone Oct 25, 2023
@silverwolfg11
Copy link
Collaborator Author

Finally added this in v3.0.0. Thanks for everyone's tips and suggestions, it really helped in implementing this! Try the alpha version and let me know if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants