-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Polygon With Holes in Dynmap/BlueMap #23
Comments
Anything from this? |
https://github.com/Chicken/BlueMap-Towny/ has holes for wilderness chunks, might be useful |
That plugin seems to use this file with algorithms for achieving holes in wilderness. I haven't had time to look into those algorithms, but I'm sure it would be possible to adapt them for MapTowny. If anyone wants to take a shot at it and PR it to MapTowny, that would be heavily appreciated. That code is licensed under GPL v3 and integrating it into the project is a little tricky. I would have to make MapTowny mostly MIT, and include a GPL portion. Since IANAL, I have no idea if that is even something I could do or if I need to do anything extra to make the project follow proper licensing. In terms of a sort of ETA on this, it will definitely be a while. I currently want to work on mapping the town blocks like Dynmap-Towny does so that both plugins can be at feature parity with each other. Then I would take a look at this. |
regions with holes are divided into segments using breadth-first search and the border-line is drawn separately. |
Finally added this in v3.0.0. Thanks for everyone's tips and suggestions, it really helped in implementing this! Try the alpha version and let me know if it doesn't work. |
Is your feature request related to a problem? Please describe.
Currently, MapTowny does not display a polygon with holes on Dynmap or BlueMap, but does display it for other web-map plugins. This makes claims rendered inaccurate since the rendered claim fills in the holes of the polygon.
Describe the solution you'd like
The holes in the polygon will not be filled in on BlueMap or Dynmap.
Describe alternatives you've considered
N/A
Additional context
Some great ideas on how to approach this were provided by PolitcubesDeveloper:
#22 (comment)
The text was updated successfully, but these errors were encountered: