Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove CDATA sections from templates #1012

Open
s2b opened this issue Nov 11, 2024 · 0 comments
Open

Don't remove CDATA sections from templates #1012

s2b opened this issue Nov 11, 2024 · 0 comments
Labels
breaking Breaking change, which requires deprecation and major release

Comments

@s2b
Copy link
Contributor

s2b commented Nov 11, 2024

The removal of all CDATA sections was introduced with 978071f without any clear indication why this was done. The consequence now is that there is no longer a "parser stop marker", for example for inline CSS interfering with Fluid's inline syntax.

Later, this was documented as a "solution" to hide invalid Fluid syntax from the Fluid parser, for example during development. Since <f:comment> now works correctly for invalid Fluid, we should consider not removing CDATA sections from templates anymore.

@s2b s2b added the breaking Breaking change, which requires deprecation and major release label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, which requires deprecation and major release
Projects
None yet
Development

No branches or pull requests

1 participant