Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Docker jobs fail, but devel jobs are fine #907

Closed
KrisThielemans opened this issue Jun 22, 2024 · 0 comments · Fixed by #908
Closed

build Docker jobs fail, but devel jobs are fine #907

KrisThielemans opened this issue Jun 22, 2024 · 0 comments · Fixed by #908

Comments

@KrisThielemans
Copy link
Member

We see in the build jobs

ERROR: test_SIRF (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_SIRF
Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/conda/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/jovyan/cil_sirf_test/test_SIRF.py", line 29, in <module>
    from cil.optimisation.utilities import AdaptiveSensitivity
ImportError: cannot import name 'AdaptiveSensitivity' from 'cil.optimisation.utilities' (/opt/conda/lib/python3.10/site-packages/cil/optimisation/utilities/__init__.py)

This is likely due to #877. The test is currently run with test_SIRF.py from CIL master.

@casperdcl what do you think? I'll create a PR anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant