Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SeleniumHQ/selenium-ide
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.0
Choose a base ref
...
head repository: SeleniumHQ/selenium-ide
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing 520 changed files with 27,866 additions and 59,819 deletions.
148 changes: 77 additions & 71 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,81 +1,87 @@
module.exports = {
"env": {
"browser": true,
"node": true,
"es6": true,
"jest": true,
"webextensions": true
env: {
browser: true,
node: true,
es6: true,
jest: true,
webextensions: true,
},
"extends": ["eslint:recommended", "plugin:react/recommended"],
"parser": "babel-eslint",
"parserOptions": {
"ecmaFeatures": {
"experimentalObjectRestSpread": true,
"jsx": true
extends: [
'eslint:recommended',
'plugin:node/recommended',
'plugin:react/recommended',
'prettier',
],
parser: 'babel-eslint',
parserOptions: {
ecmaFeatures: {
experimentalObjectRestSpread: true,
jsx: true,
legacyDecorators: true,
},
"sourceType": "module"
sourceType: 'module',
},
"plugins": [
"class-property",
"react"
overrides: [
{
files: ['**/*.ts', '**/*.tsx'],
parser: '@typescript-eslint/parser',
rules: {
'@typescript-eslint/array-type': ['error', { default: 'array' }],
'@typescript-eslint/ban-types': 'error',
'@typescript-eslint/no-unused-vars': [
'error',
{ argsIgnorePattern: '^_' },
],
'@typescript-eslint/interface-name-prefix': ['error', 'never'],
'no-dupe-class-members': 'off',
'no-unused-vars': 'off',
'no-inner-declarations': 0, // for typescript namespace
},
},
],
"rules": {
"no-trailing-spaces": [
"error"
],
"no-multiple-empty-lines": [
"error",
{ "max": 2, "maxEOF": 1 }
],
"eol-last": [
"error",
"always"
],
"comma-dangle": [
"error",
"never"
],
"indent": [
"error",
2,
{ "SwitchCase": 1 }
],
"linebreak-style": [
"error",
"unix"
],
"quotes": [
"error",
"double"
],
"semi": [
"error",
"always"
plugins: ['@typescript-eslint', 'jest', 'react', 'prettier', 'no-only-tests'],
rules: {
'prettier/prettier': 'error',
'react/prop-types': [0],
'no-const-assign': 'error',
'no-this-before-super': 'error',
'no-undef': 'error',
'no-unreachable': 'error',
'no-unused-vars': [
'error',
{ varsIgnorePattern: '^_', args: 'all', argsIgnorePattern: '^_' },
],
"no-console": [
0
],
"no-var": [
"error"
],
"no-multi-spaces": [
"error"
],
"key-spacing": [
"error",
'constructor-super': 'error',
'valid-typeof': 'error',
'no-only-tests/no-only-tests': 'error',
'node/no-unpublished-require': [
'error',
{
"beforeColon": false
}
allowModules: ['electron'],
},
],
"space-infix-ops": [
"error"
'node/no-unsupported-features/es-syntax': 0,
'node/no-unsupported-features/node-builtins': 0,
'node/shebang': [
'error',
{
convertPath: {
'src/**/*.js': ['src/(.+)$', 'dist/$1'],
'src/**/*.ts': ['src/(.+)ts$', 'dist/$1js'],
},
},
],
"comma-spacing": [
"error"
'node/no-missing-import': [
'error',
{
allowModules: ['electron'],
tryExtensions: ['.js', '.jsx', '.json', '.ts', '.tsx', '.node'],
},
],
"object-curly-spacing": [
"error",
"always"
]
}
};
},
settings: {
react: {
version: 'detect',
},
},
}
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.md
Original file line number Diff line number Diff line change
@@ -10,6 +10,8 @@ A clear and concise description of what the bug is.

<!--
Please be sure to include an SSCCE (Short, Self Contained, Correct [compilable] example) http://sscce.org/
If you have an issue with file saving, please see https://github.com/SeleniumHQ/selenium-ide/issues/363 instead. The current save behavior is a known limitation of browser extensions that we're actively working on fixing.
-->

## To Reproduce
39 changes: 38 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1 +1,38 @@
- [ ] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)
<!--
Selenium IDE is moving to an electron app!!!.
For the time being the team will support both the extension and the app, until the app reaches complete feature parity with the extension.
If you want to submit a PR to the electron app, please submit to master.
To submit a PR to the extension submit to the branch v3
-->

**Thanks for contributing to the Selenium IDE!**
**A PR well described will help maintainers to quickly review and merge it**

Before submitting your PR, please check our [contributing](https://github.com/SeleniumHQ/selenium-ide/blob/master/CONTRIBUTING.md) guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.


<!--- Provide a general summary of your changes in the Title above -->

### Description
<!--- Describe your changes in detail -->

### Motivation and Context
<!--- Why is this change required? What problem does it solve? -->

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

### Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] I have read the [contributing](https://github.com/SeleniumHQ/selenium-ide/blob/master/CONTRIBUTING.md) document.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
<!--- Provide a general summary of your changes in the Title above -->
35 changes: 35 additions & 0 deletions .github/lock.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Configuration for Lock Threads - https://github.com/dessant/lock-threads

# Number of days of inactivity before a closed issue or pull request is locked
daysUntilLock: 30

# Skip issues and pull requests created before a given timestamp. Timestamp must
# follow ISO 8601 (`YYYY-MM-DD`). Set to `false` to disable
skipCreatedBefore: false

# Issues and pull requests with these labels will be ignored. Set to `[]` to disable
exemptLabels: []

# Label to add before locking, such as `outdated`. Set to `false` to disable
lockLabel: false

# Comment to post before locking. Set to `false` to disable
lockComment: false

# Assign `resolved` as the reason for locking. Set to `false` to disable
setLockReason: false

# Limit to only `issues` or `pulls`
only: issues

# Optionally, specify configuration settings just for `issues` or `pulls`
# issues:
# exemptLabels:
# - help-wanted
# lockLabel: outdated

# pulls:
# daysUntilLock: 30

# Repository to extend settings from
# _extends: repo
62 changes: 62 additions & 0 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 14

# Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
daysUntilClose: 30

# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)
onlyLabels:
- 'reproducer required'
- 'awaiting answer'

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
# exemptLabels:
# - pinned
# - security
# - "[Status] Maybe Later"

# Set to true to ignore issues in a project (defaults to false)
exemptProjects: false

# Set to true to ignore issues in a milestone (defaults to false)
exemptMilestones: false

# Set to true to ignore issues with an assignee (defaults to false)
exemptAssignees: false

# Label to use when marking as stale
staleLabel: stale

# Comment to post when marking as stale. Set to `false` to disable
markComment: >
This issue has been automatically marked as stale because it has not had recent activity.
To keep it active, please reply with the information requested by the maintainer. Otherwise the issue will be closed in 30 days.
# Comment to post when removing the stale label.
# unmarkComment: >
# Your comment here.

# Comment to post when closing a stale Issue or Pull Request.
closeComment: >
Closing. Let us know if you feel this was closed in error, or you're now able to provide the information the maintainer requested.
# Limit the number of actions per hour, from 1-30. Default is 30
limitPerRun: 30

# Limit to only `issues` or `pulls`
only: issues

# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls':
# pulls:
# daysUntilStale: 30
# markComment: >
# This pull request has been automatically marked as stale because it has not had
# recent activity. It will be closed if no further activity occurs. Thank you
# for your contributions.

# issues:
# exemptLabels:
# - confirmed
21 changes: 13 additions & 8 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -3,15 +3,7 @@ node_modules
_MACOSX/
.DS_Store
build
packages/selenium-ide/src/selenium
packages/selenium-ide/src/atoms
packages/selenium-ide/src/webdriver
packages/selenium-ide/src/selenium-atoms
packages/selenium-ide/src/third_party
packages/selenium-ide/src/selenium-core-scripts
.peru
.idea
.tern-port
selenium-ide.pem
selenium-ide.crx
yarn-error.log
@@ -21,3 +13,16 @@ dist/
tests/webdriver/
tests/static/webdriver.js
.*.swp
website/i18n
tsconfig.tsbuildinfo
tsconfig.build.tsbuildinfo
files
drivers

# auto-generated docs
docs/api/arguments.md
docs/api/commands.md

# v3 remants when switching between branches
packages/selenium-ide/selenium/
.peru/
5 changes: 5 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"trailingComma": "es5",
"semi": false,
"singleQuote": true
}
10 changes: 6 additions & 4 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module.exports = {
"extends": "stylelint-config-standard",
"rules": {
}
};
extends: ['stylelint-config-standard', 'stylelint-config-prettier'],
plugins: ['stylelint-prettier'],
rules: {
'prettier/prettier': true,
},
}
20 changes: 0 additions & 20 deletions .tern-project

This file was deleted.

Loading