Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Semrush - Fix broken images on Newsletters and other pages #3648

Open
2 tasks
babakamyljanovssw opened this issue Feb 26, 2025 · 0 comments · Fixed by #3686
Open
2 tasks

🐛 Semrush - Fix broken images on Newsletters and other pages #3648

babakamyljanovssw opened this issue Feb 26, 2025 · 0 comments · Fixed by #3686
Labels
Type: Bug A problem with existing functionality

Comments

@babakamyljanovssw
Copy link
Member

babakamyljanovssw commented Feb 26, 2025

cc: @wicksipedia @amankumarrr

Describe the bug
Semrush report showed many several broken images on Newsletters. Actually there is an existing script to fix them, but it didn't cover all scenarios.

Script - https://github.com/SSWConsulting/SSW.Website/blob/main/scripts/fix_newsletter_images.py

Some of issues I found on URLs:

  • /images/images instead of /images
  • ../images instead of /images

Tasks

  • Refactor the script to fix broken images on Newsletters
  • Manually fix images for other pages

To Reproduce

  1. Go to https://www.semrush.com/siteaudit/campaign/16078651/review/issue/detail/13

Expected behavior
Broken images are fixed

Screenshots/Video
Image
Figure: Broken images

@babakamyljanovssw babakamyljanovssw added the Type: Bug A problem with existing functionality label Feb 26, 2025
@github-project-automation github-project-automation bot moved this to 🤷‍♂️ Needs Triage in SSW.Website Feb 26, 2025
@babakamyljanovssw babakamyljanovssw moved this from 🤷‍♂️ Needs Triage to 🔖 Backlog - Ready in SSW.Website Feb 26, 2025
@github-project-automation github-project-automation bot moved this from 🔖 Backlog - Ready to ✅ Done in SSW.Website Mar 6, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in SSW.Website Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality
Projects
Status: 🏗 In progress
1 participant