Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geocode search on mobile #1

Open
oeon opened this issue Mar 5, 2015 · 4 comments
Open

geocode search on mobile #1

oeon opened this issue Mar 5, 2015 · 4 comments
Labels

Comments

@oeon
Copy link
Member

oeon commented Mar 5, 2015

if mobile device user clicks whitespace to the left of the geocode/search magnifying glass...all kinds of errors follow

@oeon oeon added the bug label Mar 5, 2015
@bsyu1125
Copy link
Contributor

bsyu1125 commented Mar 6, 2015

The issue has to do with the input form being hidden. In Control.Geocoder.css, the input form is supposed to be hidden by changing the width and height to 0, but the width cannot be hidden for some reason. Height has successfully been changed to 0 though. Will look more into the issue on Monday.

So far the issue is only with iPhones (most likely on the ipad too).
The button is fine on @kaysabelle's galaxy s4 mini and her surface pro, users are unable to see or press on the excess white space.
Button also looks fine in Chrome.

@kaysabelle
Copy link
Member

On Firefox, there is a little whitespace to the left of the search icon. Will continue investigating this.
screenshot from 2015-03-06 13 11 37

@bsyu1125
Copy link
Contributor

bsyu1125 commented Mar 9, 2015

Looked into the Firefox problem, it seems as though every browser handles margins and pixel density differently.
Icon sizes are fixed for Chrome, Firefox, and IE 11 (didn't have time to test out older versions of IE).

Icon size is also fixed on iPhones.

There's an issue where the screen shifts to the left and reverts back on my iPhone when the search is tapped.

@oeon
Copy link
Member Author

oeon commented Mar 9, 2015

How about we file an issue https://github.com/perliedman/leaflet-control-geocoder or try another Geocoding plugin http://leafletjs.com/plugins.html ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants