Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for checking type of object (directory or file) #33

Open
DenisaCG opened this issue Jan 7, 2025 · 0 comments
Open

Fix logic for checking type of object (directory or file) #33

DenisaCG opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@DenisaCG
Copy link
Member

DenisaCG commented Jan 7, 2025

We need to fix the logic for checking if we are dealing with an object that is a directory or a simple file.

The current version relies on the directory name not including an extension as a suffix, in order to identify the directory object.

const isDir: boolean = PathExt.extname(localPath) === '';

This logic should be replaced with a helping function that properly checks the type of object we are dealing with (e.g. by listing the contents given a path).

@DenisaCG DenisaCG added the bug Something isn't working label Jan 7, 2025
@DenisaCG DenisaCG self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant