Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating import library for Python 3.13t free-threaded DLL #80

Closed
davidhewitt opened this issue Nov 29, 2024 · 4 comments · Fixed by #82
Closed

Generating import library for Python 3.13t free-threaded DLL #80

davidhewitt opened this issue Nov 29, 2024 · 4 comments · Fixed by #82
Assignees

Comments

@davidhewitt
Copy link
Member

I think we might need a separate python313t.def as well as generation options for the free-threaded build.

My reason for thinking this: symbols like PyUnstable_Module_SetGIL, which PyO3 does use, are only defined on the free-threaded build.

So I think we correspondingly might need to specifically generate a free-threaded import library? I'll try to find an example which doesn't work with the current setup.

@ravenexp ravenexp self-assigned this Nov 29, 2024
@ravenexp
Copy link
Collaborator

Makes sense. I'll try to figure out if the GitHub actions we use support co-installing 3.13 and 3.13t at the same time.

@davidhewitt
Copy link
Member Author

Awesome, thanks!

You might be interested in using https://github.com/Quansight-Labs/setup-python

Not sure about co installing but that fork does accept 3.13t as an install option.

@ravenexp
Copy link
Collaborator

You might be interested in using https://github.com/Quansight-Labs/setup-python

Not sure about co installing but that fork does accept 3.13t as an install option.

Thanks for the pointer. Microsoft support is being funny as always.

@ravenexp
Copy link
Collaborator

The implementation is done, but I'd like someone to look at the new public API before updating the documentation.
Are stringly-typed ABI tags such as "t" good enough or would an enum be more convenient to use in pyo3-build? @davidhewitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants