Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Stickiness in GSV Pane Broken in Firefox and Safari #1644

Closed
jonfroehlich opened this issue Apr 15, 2019 · 7 comments
Closed

Label Stickiness in GSV Pane Broken in Firefox and Safari #1644

jonfroehlich opened this issue Apr 15, 2019 · 7 comments

Comments

@jonfroehlich
Copy link
Member

https://youtu.be/dji9A0A5hzk

I didn't have a chance to test it in the actual labeling interface but clearly broken in the validation interface on Firefox.

@Krocketeer
Copy link

Labeling and validation interface also has similar behaviors in Safari - labels don't stay when dragging around the map.

@jonfroehlich jonfroehlich changed the title Label Stickiness in GSV Pane Broken in Firefox Label Stickiness in GSV Pane Broken in Firefox and Safari Apr 17, 2019
@misaugstad
Copy link
Member

What I've seen on Firefox is that the stickiness works on the audit page but not on the validate page.

@aileenzeng
Copy link
Member

Yep - we use our own custom code for sticking labels onto Panos (although it looks very closely related to what PanoMarkers use). I haven't done any digging to see what these exact differences are yet. For the validation interface, we have just been using the PanoMarker API since that was a lot simpler to implement. Probably means that there's a bug in the PanoMarker code then, so this might be kind of tricky to fix (eek!).

@misaugstad
Copy link
Member

yikes 😭 we should check PanoMarkers repo to see if such an issue is logged there

@aileenzeng
Copy link
Member

Oh wow! An issue is logged here (and with a fix in the comments!) marmat/google-maps-api-addons#36. We can check to see if this works on Safari too. I'll try this out now.

@jonfroehlich
Copy link
Member Author

jonfroehlich commented Apr 17, 2019

Ugh, oh no, and I was hoping we could use the PanMarker code to enable the auto-resizing the audit window (#303) and to support the mobile interfaces (which will clearly have different window sizes).

Update: Oops, I wrote this before seeing @aileenzeng's last comment. My response was to #1644 (comment)

@misaugstad
Copy link
Member

Oh my goodness, fingers crossed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants