Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Code instrumentation breaks aurelia-validation package #979

Open
hiaux0 opened this issue May 10, 2022 · 0 comments
Open

Tests: Code instrumentation breaks aurelia-validation package #979

hiaux0 opened this issue May 10, 2022 · 0 comments

Comments

@hiaux0
Copy link
Contributor

hiaux0 commented May 10, 2022

Discovered in PR 954

⚠️ There is a bug when parsing code, that has coverage-helper-code.
More specifically, aurelia-validation does not parse the helper code correctly aurelia/testing#94.
I found a fix, but would need to PR to the aurelia repo and stuff.
(Maybe we just fork ourselves, will create a ticket)
image

A fix I found is to update the parts of the regex

- $_\s\w\d\/\*.['"\]+;
+ $_\s\w\d\/\*.['"\]+();

Reported to package in question
aurelia/validation#571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants