Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Mr. Rime Egg Groups Reporting Empty #87

Closed
JoshPCodes opened this issue Jan 28, 2022 · 4 comments
Closed

Mr. Rime Egg Groups Reporting Empty #87

JoshPCodes opened this issue Jan 28, 2022 · 4 comments

Comments

@JoshPCodes
Copy link

JoshPCodes commented Jan 28, 2022

Executing the Pokemon Species endpoint for Mr. Rime returns an empty list of egg groups. This seems to be incorrect, as Bulbapedia lists it as part of the Human-like (Humanshape) egg group.

To reproduce

  1. Execute the call "https://pokeapi.co/api/v2/pokemon-species/mr-rime"
  2. Check out the egg_groups attribute. It lists 0 entries.

Expectation: The egg_groups list would contain a single entry for "humanshape"

image

@Naramsim
Copy link
Member

We probably lack that data. Would you be willing to contribute?

@JoshPCodes
Copy link
Author

Hey Naramsim! Definitely not opposed to helping out with this if it isn't terribly taxing, time permitting. Would that require some level of db access? Or is the data updated in a different manner?

@Naramsim
Copy link
Member

Hi, no, all the data is available as CSV files. It is here: https://github.com/PokeAPI/pokedex/tree/master-pokeapi/pokedex/data/csv

If you will contribute, I'd like to ask you to wait till this PR #86 is merged, otherwise you might have to fix conflicts

@JoshPCodes
Copy link
Author

I took a quick scan before I asked, and somehow I missed that directory entirely. My mistake! Thank you for pointing me in the right direction!

It actually looks like PR 86 is adding the data I noticed was missing (added line 1110 in pokemon_egg_groups.csv), amongst its several other changes. If I encounter anything similar going forward, I'll see if I can contribute an update from my end.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants