Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_versions_from_directory needs test for conflict checking #23

Open
wchristian opened this issue Sep 13, 2016 · 0 comments
Open

Comments

@wchristian
Copy link
Member

I don't have the time to make a test for this right now, thus i am documenting here what needs to be done:

In t/metadata.t the tests for package_versions_from_directory need to be extended by way of adding another file to the dist being inspected, said file needing to be stuck in a sub dir, e.g. Nested::Simple. The file should contain code sufficient to trigger the error of "Unexpected conflict in '$package'; multiple versions found.\n". Said throwing should be considered a success.

This needs to be tested because in its current state the path splitting a little further up would keep this check from functioning properly. I am providing a fix for this in a pull request to come, but a test will need to be made as per above.

wchristian added a commit to wchristian/Module-Metadata that referenced this issue Sep 13, 2016
I don't have a test for this because it would be a little more effort
than i want to give at the moment. The github issue Perl-Toolchain-Gang#23 contains
information on how the test needs to be.
wchristian added a commit to wchristian/Module-Metadata that referenced this issue Sep 13, 2016
I don't have a test for this because it would be a little more effort
than i want to give at the moment. The github issue Perl-Toolchain-Gang#23 contains
information on how the test needs to be.
wchristian added a commit to wchristian/Module-Metadata that referenced this issue Jul 19, 2018
I don't have a test for this because it would be a little more effort
than i want to give at the moment. The github issue Perl-Toolchain-Gang#23 contains
information on how the test needs to be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant