Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 8× multi sampling in traditional (non-framebuffer) MSAA #135

Closed
2 tasks done
kai-li-wop opened this issue Mar 14, 2022 · 6 comments
Closed
2 tasks done

Allow 8× multi sampling in traditional (non-framebuffer) MSAA #135

kai-li-wop opened this issue Mar 14, 2022 · 6 comments
Assignees
@kai-li-wop
Labels
enhancement New feature or request question Further information is requested
Milestone
v1.7.0

Comments

@kai-li-wop
Copy link
Member

kai-li-wop commented Mar 14, 2022 •
edited
Loading

The goal is to enable 8× multi sampling (r_ext_multisample 8) in traditional (non-framebuffer) MSAA for World of Padman

  • OpenGL 1 renderer
  • OpenGL 2 renderer

Additional questions

  • Is this also relevant for the Vulkan renderer?
  • What is r_ext_framebuffer_multisample for?
@kai-li-wop kai-li-wop added the enhancement New feature or request label Mar 14, 2022
@kai-li-wop kai-li-wop added this to the v1.7.0 milestone Mar 14, 2022
@kai-li-wop kai-li-wop self-assigned this Mar 14, 2022
@kai-li-wop
Copy link
Member Author

See: ioquake/ioq3#487

@kai-li-wop kai-li-wop moved this to Todo in WoP 1.7.x Mar 14, 2022
@kai-li-wop kai-li-wop moved this from Todo to Backlog in WoP 1.7.x Mar 14, 2022
@kai-li-wop kai-li-wop moved this from Backlog to In Progress in WoP 1.7.x Mar 15, 2022
@kai-li-wop kai-li-wop added the question Further information is requested label Mar 15, 2022
@kai-li-wop
Copy link
Member Author

Introduced with 55cd12f

@kai-li-wop kai-li-wop moved this from In Progress to Ready for Review in WoP 1.7.x Mar 15, 2022
@kai-li-wop
Copy link
Member Author

Example picture MSAA Off (see in full screen)
shot0002

Example picture MSAA 2x (see in full screen)
shot0003

Example picture MSAA 4x (see in full screen)
shot0004

Example picture MSAA 8x (see in full screen)
shot0005

@kai-li-wop kai-li-wop mentioned this issue Mar 15, 2022
Closed
@mgerhardy
Copy link
Member

There is no multisample support in the vulkan renderer yet - see de3ef9a

@mgerhardy
Copy link
Member

r_ext_framebuffer_multisample controlls the samples for fbos - http://damien.porquet.free.fr/msi/glexts/GL_EXT_framebuffer_multisample.txt.html

in other words - antialiasing for framebuffers

@kai-li-wop
Copy link
Member Author

OK, then my questions are answered. Neither the Vulkan renderer is officially supported by WoP yet, nor do we provide an option for r_ext_framebuffer_multisample in the menu. So both are irrelevant for this ticket. Thx

Repository owner moved this from Ready for Review to Done in WoP 1.7.x Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kai-li-wop kai-li-wop

Labels
enhancement New feature or request question Further information is requested
Projects
WoP 1.7.x
Archived in project
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@mgerhardy @kai-li-wop