Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge JAR process doesn't update mixin refmap JSON files? #31

Open
Kitteh6660 opened this issue May 21, 2024 · 4 comments
Open

Merge JAR process doesn't update mixin refmap JSON files? #31

Kitteh6660 opened this issue May 21, 2024 · 4 comments

Comments

@Kitteh6660
Copy link

For some reason, if I merge JAR files, and when I compare Mixin refmaps, I've noticed that it does not automatically update the refmap if I use additional relocate. That means if the mod has Mixins, it will crash.

Particularly, this would happen on Fabric and Forge because they need to have refmap that is bundled with JAR file.

I'm using Forgix 1.2.9 if that helps.

@Kitteh6660 Kitteh6660 changed the title Forgix process doesn't update mixin refmap JSON files? Merge JAR process doesn't update mixin refmap JSON files? May 21, 2024
@Ran-Mewo
Copy link
Member

What are you using additionalRelocate for? It was meant to relocate libraries

@Kitteh6660
Copy link
Author

I am using additionalRelocate for relocating Forge and Fabric-side code into their corresponding folders and it just so happens that the mixins are within those folders.

@Ran-Mewo
Copy link
Member

@Kitteh6660
It's actually intentional that Forgix doesn't touch mixins as things can break horribly if it did
There may be other ways of achieving what you're trying to do

@Kitteh6660
Copy link
Author

Just to be specific, the refmap JSON file. The JSON file below was manually done by hand because otherwise, Forge mixin refmap will try to refer to the wrong location and thus crashes the game. As a result, updating Mixin class files can be a bit tedious process. Which thankfully, am planning to ditch Forge entirely in 1.21.

dramaticdoors_forge.refmap.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants