Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Better IPv6 support #6

Open
Kagee opened this issue Feb 7, 2021 · 1 comment · May be fixed by #11
Open

[Request] Better IPv6 support #6

Kagee opened this issue Feb 7, 2021 · 1 comment · May be fixed by #11
Labels
request New feature or request up for grabs Issue/FR will not be worked on, open for a member of the community to take it on

Comments

@Kagee
Copy link

Kagee commented Feb 7, 2021

Is your feature request related to a problem? Please describe.
The current IPV6 support is limited to a single IPv6 CIDR, and written with (unusual) large characters. In a network with proper IPv6 support (not just link-local), browser are free to select any of the avaliable IPv6 adresses of a host for connections. Thus allowing just link-local adresses are not enough.

Describe the solution you'd like
If possible, i would suggest re-using the MIT licensed code from https://github.com/sindresorhus/ip-regex.
CIDR support could be implemented by using the code in https://github.com/silverwind/cidr-regex, or by splitting the input string on /, making sure there are only two groups, and making sure the second group is [0 - 32] for IPv4, and [0-128] for IPv6.

If you require any help for testing or have questions, I may be able to help.

@cp2004
Copy link
Member

cp2004 commented Feb 15, 2021

I can give something like this a go in the future, it is not necessarily high priority - you can bypass validation by adding a valid configuration, then edit it - the plugin was deliberately designed this way.

If you have good ideas to adjust the current validation, a PR would be awesome - I don't currently have the time for this, but it is still on my mind. I might have created too many things to keep up with...

@cp2004 cp2004 added the request New feature or request label Apr 19, 2021
@cp2004 cp2004 added the up for grabs Issue/FR will not be worked on, open for a member of the community to take it on label Oct 29, 2021
@eerielg eerielg linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request up for grabs Issue/FR will not be worked on, open for a member of the community to take it on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants