From 584e1c825f2df329775f47ee82fcd7152e5bf37a Mon Sep 17 00:00:00 2001
From: Joakim Bech <joakim.bech@linaro.org>
Date: Thu, 26 Sep 2024 12:53:36 +0200
Subject: [PATCH] ta: change ta parameter checking example

Change the example code for parameter checking to a way that is easier
to both read and write and that we commonly use.

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
---
 building/trusted_applications.rst | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/building/trusted_applications.rst b/building/trusted_applications.rst
index 26be445..accf555 100644
--- a/building/trusted_applications.rst
+++ b/building/trusted_applications.rst
@@ -323,12 +323,13 @@ sequence:
     TEE_Result handle_command_0(void *session, uint32_t cmd_id,
                                 uint32_t param_types, TEE_Param params[4])
     {
-        if ((TEE_PARAM_TYPE_GET(param_types, 0) != TEE_PARAM_TYPE_VALUE_IN) ||
-            (TEE_PARAM_TYPE_GET(param_types, 1) != TEE_PARAM_TYPE_VALUE_OUT) ||
-            (TEE_PARAM_TYPE_GET(param_types, 2) != TEE_PARAM_TYPE_MEMREF_INOUT) ||
-            (TEE_PARAM_TYPE_GET(param_types, 3) != TEE_PARAM_TYPE_NONE)) {
-            return TEE_ERROR_BAD_PARAMETERS
-        }
+        uint32_t exp_param_types = TEE_PARAM_TYPES(TEE_PARAM_TYPE_VALUE_INPUT,
+                                                   TEE_PARAM_TYPE_VALUE_OUTPUT,
+                                                   TEE_PARAM_TYPE_MEMREF_INOUT,
+                                                   TEE_PARAM_TYPE_NONE);
+
+        if (param_types != exp_param_types)
+            return TEE_ERROR_BAD_PARAMETERS;
 
         /* process command */
         ...