Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept some setting to run in a path #27

Open
fernandocollova opened this issue Mar 19, 2018 · 0 comments
Open

Accept some setting to run in a path #27

fernandocollova opened this issue Mar 19, 2018 · 0 comments

Comments

@fernandocollova
Copy link

fernandocollova commented Mar 19, 2018

What happens?

When running behind a proxy, (in my case, Apache adding SSL to the connection) the app doesn't honor the X suite of headers, and also doens't have any settings so one can run it in /playmaker for example.

What should happen?

The app could have the xheaders argument set to True when calling tornado.httpserver.HTTPServer and some way, maybe an env var, to set the app to "tune" the urls to other dict.

How to reproduce?

Basically, try to access the app behind any proxy using a path different from /. For example, this apache ProxyPass settings stops the app from loading any static files.

<Location "/playmaker">
ProxyPass "http://127.0.0.1:5000"
ProxyPassReverse "http://127.0.0.1:5000"
Require ip 192.168.1.0/24

Some meta

I have transmission, nextcloud, and other apps running in the same host, and it just feels wrong to have this in "/" when I could have it properly configured in it's onw path. Also, most of those services I use have by default a leading path, so maybe this app can have it as well? Would you accept a pull request for that or some other way (as an env var) to set that path? Or maybe both, a default that's used if no env is provided?

The thing I again just can help is the JS part, as I don't know any of that. But I guess if the path is hard-coded it shouldn't be too difficult to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant