Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement predict logic based on the spectra data #19

Open
CS76 opened this issue Jul 20, 2023 · 1 comment
Open

Implement predict logic based on the spectra data #19

CS76 opened this issue Jul 20, 2023 · 1 comment
Assignees

Comments

@CS76
Copy link
Member

CS76 commented Jul 20, 2023

image
@stefhk3
Copy link
Collaborator

stefhk3 commented Jul 21, 2023

Just one comment here: I found it matters to try to optimize things in the loop as much as possible. Since we do the prediction for potentially many atoms in a molecule and each atom requires potentially many fallbacks, small amounts of time add up. So it might make sense to generate the HOSE code once outside the loop and then split the string by separator in the loop instead of newly generating an x sphere hose code in each loop iteration. Also, the speed of the query is important. In MySQL, the like operator uses indexes, as opposed to some other operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants