Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update broke account managing (v0.7.0-4154) (Worked last update, I think) + 1 other bug #5560

Open
1 task done
AydanSummers opened this issue Jan 13, 2025 · 3 comments
Labels

Comments

@AydanSummers
Copy link

Operating System

Windows

Description of bug

First thing I did after the update was clear all my accounts to start reading them since i didn't immediately see how to sign back into the Microsoft accounts linked to each account (I've been maining one to two accounts for a while but decided to finally fix the others). Then i started adding them one by one and noticed a few issues with the account manager as well as the new skin manager features.

Skin manager bugs:

  • Skins uploaded as classic skins but used as slim skins display as all black in the new skin viewer
  • Skins uploaded as classic skins but used as slim skins do not get saved when clicking "Save Skin To File"
  • Skins that are classic skins cannot be used as slim skins (They should allow this as does Microsoft's skin "manager")

Steps to reproduce

Account manager bugs:

Take 1:
1 - Sign into account
2 - Sign into another account
3 - Launch random vanilla build (24w18a)
4 - Account needs to be manually signed into???

Take 2:
1 - Clear all accounts and sign into ONE account
2 - Launch random vanilla build (24w18a)
3 - It worked and let me into the game

Take 3:
1 - Clear all accounts and sign into ONE account
2 - Immediately refresh accounts
3 - It worked

Take 4:
1 - Repeat take 2
2 - Sign into second account
3 - Click refresh
4 - First account expired and second account Online???

Suspected cause

No response

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@AydanSummers
Copy link
Author

AydanSummers commented Jan 13, 2025

Wanted to play MC a bit but looks like I'm gonna wait for the next release.

Edit: Forgot to do labels beyond "bug"

@AydanSummers AydanSummers changed the title Latest update broke account managing (v0.7.0-4154) (Worked last update) + 1 other bug Latest update broke account managing (v0.7.0-4154) (Worked last update, I think) + 1 other bug Jan 13, 2025
peterix added a commit that referenced this issue Jan 15, 2025
This actually dumbs down detection of skins that would be broken
as 'Classic' skins, but maybe we can do that better later.
@peterix
Copy link
Member

peterix commented Jan 15, 2025

Not sure about the other issues you mention here. Looks more like Mojang/MS services being unreliable.

There are some things I can improve by preventing some of the token refreshes because we run into rate limits, but that's basically it...

@AydanSummers
Copy link
Author

Not sure about the other issues you mention here. Looks more like Mojang/MS services being unreliable.

There are some things I can improve by preventing some of the token refreshes because we run into rate limits, but that's basically it...

ill try again here and there and get back reply back but i brought this up because i've never had this problem before (I've been using 5-7 accounts logging in and out on and off for years)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants