Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass headers through on HttpException class #328

Closed
baileywickham opened this issue Oct 25, 2024 · 1 comment
Closed

Pass headers through on HttpException class #328

baileywickham opened this issue Oct 25, 2024 · 1 comment
Labels
wontfix Indicates that, while acknowledged, the particular issue or request won't be acted upon.

Comments

@baileywickham
Copy link

For handling rate limits, I'd like to use the headers referenced here. To do this, an HTTPException needs to pass have the http headers of a response as an attribute. I'm happy to implement this, let me know if this is something you'd accept a PR on.

@baileywickham baileywickham changed the title Pass headers through on HTTPException class Pass headers through on HttpException class Oct 25, 2024
@baileywickham
Copy link
Author

Ah, after looking further into it, it looks like the response object is a child of the cause of the error in the case where the error is an Axios error. One improvement would be typing that or providing handlers but the data is there. Feel free to close this issue if you consider it closed.

@MrRefactoring MrRefactoring added the wontfix Indicates that, while acknowledged, the particular issue or request won't be acted upon. label Jan 9, 2025
@MrRefactoring MrRefactoring closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Indicates that, while acknowledged, the particular issue or request won't be acted upon.
Projects
None yet
Development

No branches or pull requests

2 participants