Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom nonce toggle makes no difference unless Advanced Detail Button is actioned in send screen #29512

Open
benjisclowder opened this issue Jan 8, 2025 · 0 comments
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@benjisclowder
Copy link
Contributor

Describe the bug

The Advanced Detail Button in Send screen does not fetch the toggle status (ON/OFF) from the Custom transaction nonce setting in advanced, and acts individually - this makes the Custom transaction nonce button useless.

Expected behavior

Toggle status is passed on from Advanced settings to the Advanced Detail Button in Send screen

Maybe this is expected behavior from the Advanced Detail Button, but it makes the Custom transaction nonce button useless, so we should clarify what is expected here, because regardless of the Custom transaction nonce being enabled or disabled, we still have to action the Advanced Detail Button to have nonce displayed in the send screen.

Screenshots/Recordings

Screen.Recording.2025-01-08.at.17.44.25.mov

Steps to reproduce

  1. Load MetaMask
  2. Go to Settings --> Advanced --> Custom transaction nonce
  3. Enable Custom transaction nonce
  4. Go to Send screen --> Continue
  5. Notice the nonce is not visible
  6. Click on the Avanced Detail Button (upper right corner)
  7. Notice the nonce is displayed
  8. Click again on the Avanced Detail Button to disable it and return to Settings --> Advanced --> Custom transaction nonce
  9. Notice this toggle is still ON.

Error messages or log output

Detection stage

In production (default)

Version

12.10.0, 12.9.0, 12.8.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@benjisclowder benjisclowder added Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 8, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

1 participant