Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dark theme #97

Open
KeziahMoselle opened this issue Sep 16, 2020 · 5 comments
Open

Feature: dark theme #97

KeziahMoselle opened this issue Sep 16, 2020 · 5 comments
Labels
feature New feature or request good first issue Good for newcomers

Comments

@KeziahMoselle
Copy link
Owner

Implement a dark theme that will change all white colors to something darker.

@KeziahMoselle KeziahMoselle added feature New feature or request good first issue Good for newcomers labels Sep 16, 2020
@divya661
Copy link

@KeziahMoselle I would like to work on this feature & update you as soon as possible regarding the changes. Could you please assign it to me.
Looking forward to hearing from you soon.

@KeziahMoselle
Copy link
Owner Author

@divya661 feel free to work on this !
I think it will need a refactor of the CSS colors using CSS variables for light & dark theme so it will be simpler to maintain in the future 👍 thank you for your interest in this project !

@divya661
Copy link

divya661 commented Sep 25, 2020

@KeziahMoselle I read on the web, that this feature could be implemented using nativeTheme module of the electron along with dynamically specifying which css needed to be used. The advantage of this is going to be, if the user System OS is set to dark mode by default/at point of time then the app settings will also be enabled to dark mode.

I'll be able to work on this, but it might take 3-4 days, as I haven't worked with electron before.

@divya661
Copy link

Are there any other medium too, where I can contact you regarding the issues/queries I face during working on it like discord/gmail/linkedIn/etc to get quick responses.

@KeziahMoselle
Copy link
Owner Author

KeziahMoselle commented Sep 25, 2020

Yes that's a great idea @divya661 ! Looking forward to it 😄

Sure, you can contact me on Discord : Nemesis#6631, feel free to chat with me if you have any questions regarding the source code or something else 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants