Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for JsonSchema in CanvasForm #1913

Open
lordrip opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1939
Open

Improve support for JsonSchema in CanvasForm #1913

lordrip opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1939
Assignees
Labels
canvas/config-form Configuration form related issues catalog Catalog-related issues user interface

Comments

@lordrip
Copy link
Member

lordrip commented Jan 14, 2025

Please describe the feature that you want to propose

Context

Currently, we're using uniforms-patternfly for rendering the forms, but there's only partial support for anyOf / oneOf, meaning that we can't support EIPs like resequence, because it has 2 elements inside of anyOf #794.

We also tried https://github.com/rjsf-team/react-jsonschema-form and while it has good support for anyOf / oneOf out of the box, it's not enough for the aforementioned resequence EIP.

In addition to that, we needed to add special handling starting from the Camel catalog generator up to the form library to support especial cases like Dataformat, Expression, Loadbalancer, etc, adding more maintenance to the project.

Goal

The goal for this ticket is to come up with a plan to improve this scenario so we can support more things out of the box and reduce the complexity of both the catalog generator and the form library handling.

The new approach to the CanvasForm should bring:

  1. Remove the need to handle special cases like Dataformat, Expression, Loadbalancer.
  2. Support multiple elements inside anyOf.
  3. Support special EIPs like resequence out of the box.
@lordrip lordrip added catalog Catalog-related issues canvas/config-form Configuration form related issues user interface labels Jan 14, 2025
@apupier apupier moved this from New to Backlog in Kanban Board Jan 14, 2025
@shivamG640 shivamG640 self-assigned this Jan 16, 2025
@shivamG640 shivamG640 moved this from Backlog to In Progress in Kanban Board Jan 21, 2025
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 23, 2025
This commit adds support for anyOf & oneOf so it better reflects the
Caml YAML DSL schema.

fix: KaotoIO#1934
fix: KaotoIO#1913
fix: KaotoIO#794
@lordrip lordrip linked a pull request Jan 23, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/config-form Configuration form related issues catalog Catalog-related issues user interface
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants