From e68767fc1334958ecceb7efbc78bb39076a49f3f Mon Sep 17 00:00:00 2001 From: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Date: Tue, 21 Jan 2025 13:17:32 +0900 Subject: [PATCH] Fix: Linked featured image block cannot be selected correctly (#68775) Co-authored-by: t-hamano Co-authored-by: carolinan --- .../src/post-featured-image/edit.js | 17 ++--------------- .../src/post-featured-image/editor.scss | 4 ++-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/packages/block-library/src/post-featured-image/edit.js b/packages/block-library/src/post-featured-image/edit.js index 05888c41fecf23..6afe2c29e25045 100644 --- a/packages/block-library/src/post-featured-image/edit.js +++ b/packages/block-library/src/post-featured-image/edit.js @@ -49,11 +49,6 @@ function getMediaSourceUrlBySizeSlug( media, slug ) { ); } -const disabledClickProps = { - onClick: ( event ) => event.preventDefault(), - 'aria-disabled': true, -}; - export default function PostFeaturedImageEdit( { clientId, attributes, @@ -318,11 +313,7 @@ export default function PostFeaturedImageEdit( { { controls }
{ !! isLink ? ( - + { placeholder() } ) : ( @@ -430,11 +421,7 @@ export default function PostFeaturedImageEdit( {
{ /* If the featured image is linked, wrap in an tag to trigger any inherited link element styles */ } { !! isLink ? ( - + { image } ) : ( diff --git a/packages/block-library/src/post-featured-image/editor.scss b/packages/block-library/src/post-featured-image/editor.scss index 5fab62c571b1cf..3295fe14e62ac2 100644 --- a/packages/block-library/src/post-featured-image/editor.scss +++ b/packages/block-library/src/post-featured-image/editor.scss @@ -100,9 +100,9 @@ // When the Post Featured Image block is linked, // it's wrapped with a disabled tag. - // Restore cursor style so it doesn't appear 'clickable'. + // Ensure that the link is not clickable. > a { - cursor: default; + pointer-events: none; } // When the Post Featured Image block is linked,