Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not being run on PRs #309

Open
ararslan opened this issue Nov 17, 2024 · 2 comments
Open

Tests are not being run on PRs #309

ararslan opened this issue Nov 17, 2024 · 2 comments

Comments

@ararslan
Copy link
Member

ararslan commented Nov 17, 2024

I'm not actually sure how CI was set up initially but tests are no longer being run. This repo is also still using bors, which is no longer a thing. It's possible that reinstating CI could be as simple as swapping bors for GitHub Actions but I'm unsure and haven't looked into it at all.

EDIT: Okay I looked into it briefly, the tests are running (and passing) on cron, I think we just need to enable them to run on PRs in the GHA config?

@ararslan ararslan changed the title Tests are not being run on CI Tests are not being run on PRs Nov 17, 2024
@ericphanson
Copy link
Member

xref JuliaCloud/AWS.jl#630, where it was discussed how to use the "require approval for new contributors" setting to gate access to real-s3 which I think we'd want to do here

@mattBrzezinski
Copy link
Member

xref JuliaCloud/AWS.jl#630, where it was discussed how to use the "require approval for new contributors" setting to gate access to real-s3 which I think we'd want to do here

I've dropped bors being a required check before merging, we already had it but confirming that 1st time contributors require approval for CI runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants